Create RtcpDemuxer

webrtc/call/rtp_rtcp_demuxer_helper.h

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_CALL_RTP_RTCP_DEMUXER_HELPER_H_
+#define WEBRTC_CALL_RTP_RTCP_DEMUXER_HELPER_H_
+
+#include <algorithm>
+#include <map>
+#include <utility>
+
+#include "webrtc/base/array_view.h"
+#include "webrtc/base/basictypes.h"
+
+namespace webrtc {
+
+template <typename Container,
+          typename Key = typename Container::key_type,
+          typename Value = typename Container::value_type>
+bool MultimapAssociationExists(const Container& multimap, Key key, Value val) {
+  auto it_range = multimap.equal_range(key);
+  using Reference = typename Container::const_reference;
+  return std::any_of(it_range.first, it_range.second,
+                     [val](Reference elem) { return elem.second == val; });
+}
+
+template <typename Container, typename Value = typename Container::value_type>
+size_t RemoveFromMultimapByValue(Container* multimap, const Value value) {

[danilchap, 2017/06/16 16:46:19]

const Value& value
or
Value value

[eladalon, 2017/06/19 11:28:47]

(const Value&) was intended; thanks for catching.

+  size_t count = 0;
+  for (auto it = multimap->begin(); it != multimap->end();) {
+    if (it->second == value) {
+      it = multimap->erase(it);
+      ++count;
+    } else {
+      ++it;
+    }
+  }
+  return count;
+}
+
+template <typename Container, typename Key = typename Container::key_type>

[danilchap, 2017/06/16 16:46:19]

why do you need default value for Key?
since both template parameters are used as function parameters, compile can find
out them automatically.

[eladalon, 2017/06/19 11:28:47]

I was thinking of this as self-documenting code, but okay - removed.

+bool ContainerHasKey(const Container& c, const Key& k) {
+  return std::find(c.cbegin(), c.cend(), k) != c.cend();
+}
+
+template <typename Container,
+          typename Key = typename Container::key_type,
+          typename Value = typename Container::value_type>
+bool AssociativeContainerHasValue(const Container& c, const Value& v) {
+  auto predicate = [v](const std::pair<Key, Value>& it) {
+    return it.second == v;
+  };
+  return std::any_of(c.cbegin(), c.cend(), predicate);
+}
+
+bool ParseSenderSsrc(rtc::ArrayView<const uint8_t> packet,

[danilchap, 2017/06/16 16:46:19]

Ensure function name mention it extract ssrc from an rtcp packet.

consider returning rtc::Optional<uint32_t> instead of having an output
parameter.

[eladalon, 2017/06/19 11:28:47]

Done.

+                     uint32_t* ssrc_sender);
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_CALL_RTP_RTCP_DEMUXER_HELPER_H_