Add has_value() and value() methods to rtc::Optional.

webrtc/base/optional_unittest.cc

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 138 matching lines @@
   return strings;
 }
 
 }  // namespace
 
 TEST(OptionalTest, TestConstructDefault) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     EXPECT_FALSE(x);
+    EXPECT_FALSE(x.has_value());
   }
   EXPECT_EQ(V(), *log);
 }
 
 TEST(OptionalTest, TestConstructCopyEmpty) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     EXPECT_FALSE(x);
+    EXPECT_FALSE(x.has_value());
     auto y = x;
     EXPECT_FALSE(y);
+    EXPECT_FALSE(y.has_value());
   }
   EXPECT_EQ(V(), *log);
 }
 
 TEST(OptionalTest, TestConstructCopyFull) {
   auto log = Logger::Setup();
   {
     Logger a;
     Optional<Logger> x(a);
     EXPECT_TRUE(x);
+    EXPECT_TRUE(x.has_value());
     log->push_back("---");
     auto y = x;
     EXPECT_TRUE(y);
+    EXPECT_TRUE(y.has_value());
     log->push_back("---");
   }
   EXPECT_EQ(V("0:0. default constructor", "1:0. copy constructor (from 0:0)",
               "---", "2:0. copy constructor (from 1:0)", "---",
               "2:0. destructor", "1:0. destructor", "0:0. destructor"),
             *log);
 }
 
 TEST(OptionalTest, TestConstructMoveEmpty) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x;
     EXPECT_FALSE(x);
+    EXPECT_FALSE(x.has_value());
     auto y = std::move(x);
     EXPECT_FALSE(y);
+    EXPECT_FALSE(y.has_value());
   }
   EXPECT_EQ(V(), *log);
 }
 
 TEST(OptionalTest, TestConstructMoveFull) {
   auto log = Logger::Setup();
   {
     Optional<Logger> x(Logger(17));
     EXPECT_TRUE(x);
+    EXPECT_TRUE(x.has_value());
     log->push_back("---");
     auto y = std::move(x);
     EXPECT_TRUE(x);
+    EXPECT_TRUE(x.has_value());
     EXPECT_TRUE(y);
+    EXPECT_TRUE(y.has_value());
     log->push_back("---");
   }
   EXPECT_EQ(
       V("0:17. explicit constructor", "1:17. move constructor (from 0:17)",
         "0:17. destructor", "---", "2:17. move constructor (from 1:17)", "---",
         "2:17. destructor", "1:17. destructor"),
       *log);
 }
 
 TEST(OptionalTest, TestCopyAssignToEmptyFromEmpty) {
@@ skipping 393 matching lines @@
     x->Foo();
     y->Foo();
     std::move(x)->Foo();
     std::move(y)->Foo();
     log->push_back("---");
     (*x).Foo();
     (*y).Foo();
     (*std::move(x)).Foo();
     (*std::move(y)).Foo();
     log->push_back("---");
+    x.value().Foo();
+    y.value().Foo();
+    std::move(x).value().Foo();
+    std::move(y).value().Foo();
+    log->push_back("---");
   }
+  // clang-format off
   EXPECT_EQ(V("0:42. explicit constructor",
-              "1:42. move constructor (from 0:42)", "0:42. destructor", "---",
-              "1:42. Foo()", "1:42. Foo() const", "1:42. Foo()",
-              "1:42. Foo() const", "---", "1:42. Foo()", "1:42. Foo() const",
-              "1:42. Foo()", "1:42. Foo() const", "---", "1:42. destructor"),
+              "1:42. move constructor (from 0:42)",
+              "0:42. destructor",
+              "---",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "---",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "---",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "1:42. Foo()",
+              "1:42. Foo() const",
+              "---",
+              "1:42. destructor"),
             *log);
+  // clang-format on
 }
 
 TEST(OptionalTest, TestDereferenceWithDefault) {
   auto log = Logger::Setup();
   {
     const Logger a(17), b(42);
     Optional<Logger> x(a);
     Optional<Logger> y;
     log->push_back("-1-");
     EXPECT_EQ(a, x.value_or(Logger(42)));
@@ skipping 149 matching lines @@
   // for MyPrintableType never getting called.
   const MyPrintableType dont_warn{17};
   const MyOstreamPrintableType dont_warn2{18};
   std::stringstream sstr;
   sstr << dont_warn;
   PrintTo(dont_warn, &sstr);
   sstr << dont_warn2;
 }
 
 }  // namespace rtc