Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: webrtc/call/rtp_demuxer.h

Issue 2941513002: Log an error in RtpDemuxer::FindSsrcAssociations() if kMaxProcessedSsrcs exceeded (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // one-to-one association with an SSRC, but that SSRC is not yet known. 63 // one-to-one association with an SSRC, but that SSRC is not yet known.
64 // When it becomes known, the association of the sink to the RSID is deleted 64 // When it becomes known, the association of the sink to the RSID is deleted
65 // from this container, and moved into |sinks_|. 65 // from this container, and moved into |sinks_|.
66 std::multimap<std::string, RtpPacketSinkInterface*> rsid_sinks_; 66 std::multimap<std::string, RtpPacketSinkInterface*> rsid_sinks_;
67 67
68 // Iterating over |rsid_sinks_| for each incoming and performing multiple 68 // Iterating over |rsid_sinks_| for each incoming and performing multiple
69 // string comparisons is of non-trivial cost. To avoid this cost, we only 69 // string comparisons is of non-trivial cost. To avoid this cost, we only
70 // check RSIDs for the first packet on each incoming SSRC stream. 70 // check RSIDs for the first packet on each incoming SSRC stream.
71 // (If RSID associations are added later, we check again.) 71 // (If RSID associations are added later, we check again.)
72 std::set<uint32_t> processed_ssrcs_; 72 std::set<uint32_t> processed_ssrcs_;
73
74 // Avoid an attack that would create excessive logging.
75 bool logged_max_processed_ssrcs_exceeded_ = false;
73 }; 76 };
74 77
75 } // namespace webrtc 78 } // namespace webrtc
76 79
77 #endif // WEBRTC_CALL_RTP_DEMUXER_H_ 80 #endif // WEBRTC_CALL_RTP_DEMUXER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698