Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

Issue 2941253002: Tune loss-based BWE to be more compatible with the low frequency loss reports of audio streams. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 15 matching lines...) Expand all
26 namespace { 26 namespace {
27 const int64_t kBweIncreaseIntervalMs = 1000; 27 const int64_t kBweIncreaseIntervalMs = 1000;
28 const int64_t kBweDecreaseIntervalMs = 300; 28 const int64_t kBweDecreaseIntervalMs = 300;
29 const int64_t kStartPhaseMs = 2000; 29 const int64_t kStartPhaseMs = 2000;
30 const int64_t kBweConverganceTimeMs = 20000; 30 const int64_t kBweConverganceTimeMs = 20000;
31 const int kLimitNumPackets = 20; 31 const int kLimitNumPackets = 20;
32 const int kDefaultMaxBitrateBps = 1000000000; 32 const int kDefaultMaxBitrateBps = 1000000000;
33 const int64_t kLowBitrateLogPeriodMs = 10000; 33 const int64_t kLowBitrateLogPeriodMs = 10000;
34 const int64_t kRtcEventLogPeriodMs = 5000; 34 const int64_t kRtcEventLogPeriodMs = 5000;
35 // Expecting that RTCP feedback is sent uniformly within [0.5, 1.5]s intervals. 35 // Expecting that RTCP feedback is sent uniformly within [0.5, 1.5]s intervals.
36 const int64_t kFeedbackIntervalMs = 1500; 36 const int64_t kFeedbackIntervalMs = 5000;
37 const int64_t kFeedbackTimeoutIntervals = 3; 37 const int64_t kFeedbackTimeoutIntervals = 3;
38 const int64_t kTimeoutIntervalMs = 1000; 38 const int64_t kTimeoutIntervalMs = 1000;
39 39
40 const float kDefaultLowLossThreshold = 0.02f; 40 const float kDefaultLowLossThreshold = 0.02f;
41 const float kDefaultHighLossThreshold = 0.1f; 41 const float kDefaultHighLossThreshold = 0.1f;
42 const int kDefaultBitrateThresholdKbps = 0; 42 const int kDefaultBitrateThresholdKbps = 0;
43 43
44 struct UmaRampUpMetric { 44 struct UmaRampUpMetric {
45 const char* metric_name; 45 const char* metric_name;
46 int bitrate_kbps; 46 int bitrate_kbps;
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 last_fraction_loss_ != last_logged_fraction_loss_ || 411 last_fraction_loss_ != last_logged_fraction_loss_ ||
412 now_ms - last_rtc_event_log_ms_ > kRtcEventLogPeriodMs) { 412 now_ms - last_rtc_event_log_ms_ > kRtcEventLogPeriodMs) {
413 event_log_->LogLossBasedBweUpdate(bitrate_bps, last_fraction_loss_, 413 event_log_->LogLossBasedBweUpdate(bitrate_bps, last_fraction_loss_,
414 expected_packets_since_last_loss_update_); 414 expected_packets_since_last_loss_update_);
415 last_logged_fraction_loss_ = last_fraction_loss_; 415 last_logged_fraction_loss_ = last_fraction_loss_;
416 last_rtc_event_log_ms_ = now_ms; 416 last_rtc_event_log_ms_ = now_ms;
417 } 417 }
418 current_bitrate_bps_ = bitrate_bps; 418 current_bitrate_bps_ = bitrate_bps;
419 } 419 }
420 } // namespace webrtc 420 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698