ran git cl format webrtc/sdk/android/

ran git cl format webrtc/sdk/android/


changed AUTHORS


update aspect ratio when TextureView size is updated


change pipRenderer to SurfaceViewRendered


Added TextureViewRenderer class. This class uses a TextureView to render the video

BUG=webrtc:7816

[jpbrahma, 2017-06-14 23:12:45]

The CQ bit was checked by jpbrahma@gmail.com

[commit-bot: I haz the power, 2017-06-14 23:12:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-14 23:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 23:13:00]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[jpbrahma, 2017-06-14 23:14:48]

The CQ bit was checked by jpbrahma@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 23:14:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-14 23:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 23:14:59]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[jpbrahma, 2017-06-14 23:18:13]

Description was changed from

==========
ran git cl format webrtc/sdk/android/


changed AUTHORS


update aspect ratio when TextureView size is updated


change pipRenderer to SurfaceViewRendered


Added TextureViewRenderer class. This class uses a TextureView to render the
video

BUG=webrtc:7816
==========

to

==========
ran git cl format webrtc/sdk/android/


changed AUTHORS


update aspect ratio when TextureView size is updated


change pipRenderer to SurfaceViewRendered


Added TextureViewRenderer class. This class uses a TextureView to render the
video

BUG=webrtc:7816
==========

[jpbrahma, 2017-06-14 23:23:26]

jpbrahma@gmail.com changed reviewers:
+ henrika@webrtc.org, kwiberg@webrtc.org, mflodman@webrtc.org,
niklas.enbom@webrtc.org, tina.legrand@webrtc.org, tommi@webrtc.org

[jpbrahma, 2017-06-14 23:23:27]

Added TextureViewRenderer class. This class uses a TextureView to render the
video

Updated AppRtc to use TextureViewRenderer class for pip renderer.

[henrika_webrtc, 2017-06-15 07:28:10]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org
- henrika@webrtc.org, kwiberg@webrtc.org, mflodman@webrtc.org,
niklas.enbom@webrtc.org, tina.legrand@webrtc.org, tommi@webrtc.org

[jpbrahma, 2017-06-15 12:40:30]

The CQ bit was checked by jpbrahma@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 12:40:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-15 12:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 12:40:35]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[magjed_webrtc, 2017-06-15 19:17:15]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org
- magjed@webrtc.org

[sakal, 2017-06-16 07:47:02]

https://codereview.webrtc.org/2938103002/diff/1/webrtc/examples/androidapp/sr...
File webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
(right):

https://codereview.webrtc.org/2938103002/diff/1/webrtc/examples/androidapp/sr...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:165: private
TextureViewRenderer fullscreenRenderer;
Please do not change this or make it a setting.

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java (right):

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java:118: * @param
drawerParam   Custom drawer to use for this frame listener.
Please fix the formatting if you want to change this.

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/TextureViewRenderer.java (right):

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/TextureViewRenderer.java:248:
adjustAspectRatio(surfaceWidth, surfaceHeight);
This doesn't change the surface size?

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/TextureViewRenderer.java:251: surfaceWidth =
surfaceHeight = 0;
We have to somehow reset the surface size

https://codereview.webrtc.org/2938103002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/TextureViewRenderer.java:259: private void
adjustAspectRatio(int videoWidth, int videoHeight) {
This method is not needed if you correctly call setLayoutAspectRatio, it set a
matrix that renders correctly on the surface.

[sakal, 2017-07-27 11:18:45]

sakal@webrtc.org changed reviewers:
- sakal@webrtc.org