Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2937273002: Starting with patch 34 from https://codereview.webrtc.org/2854123003/ (Closed)

Created:
3 years, 6 months ago by Taylor Brandstetter
Modified:
3 years, 6 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, mflodman, kwiberg-webrtc, stefan-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Starting with patch 34 from https://codereview.webrtc.org/2854123003/

Patch Set 1 #

Patch Set 2 : Merge with master #

Patch Set 3 : Simplifying thread stuff, which is possible since https://codereview.webrtc.org/2934103002/ landed #

Patch Set 4 : Fix iOS sim build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+736 lines, -630 lines) Patch
M webrtc/api/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 chunk +8 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 2 5 chunks +52 lines, -1 line 0 comments Download
M webrtc/call/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/call/call.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A webrtc/call/callfactory.h View 1 chunk +26 lines, -0 lines 0 comments Download
A webrtc/call/callfactory.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/call/callfactoryinterface.h View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/common_video/h264/profile_level_id.h View 1 chunk +3 lines, -86 lines 0 comments Download
D webrtc/common_video/h264/profile_level_id.cc View 1 chunk +0 lines, -304 lines 0 comments Download
M webrtc/logging/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 chunk +0 lines, -9 lines 0 comments Download
A webrtc/logging/rtc_event_log/rtc_event_log_factory.h View 1 chunk +30 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/rtc_event_log_factory.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/logging/rtc_event_log/rtc_event_log_factory_interface.h View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 8 chunks +76 lines, -32 lines 0 comments Download
M webrtc/media/base/codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/fakemediaengine.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + webrtc/media/base/h264_profile_level_id.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/media/base/h264_profile_level_id.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 2 3 7 chunks +63 lines, -10 lines 0 comments Download
M webrtc/pc/channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/channel.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 4 chunks +25 lines, -1 line 0 comments Download
A webrtc/pc/createpeerconnectionfactory.cc View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
M webrtc/pc/mediasession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/peerconnection.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 3 chunks +6 lines, -24 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.h View 1 3 chunks +12 lines, -5 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 2 10 chunks +82 lines, -115 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 4 chunks +51 lines, -6 lines 0 comments Download
M webrtc/pc/rtpsender.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/pc/test/mock_peerconnection.h View 3 chunks +19 lines, -3 lines 0 comments Download
M webrtc/pc/webrtcsession.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource_jni.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Taylor Brandstetter
The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 17:33:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2937273002/60001
3 years, 6 months ago (2017-06-15 17:33:14 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 17:38:42 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 17:38:44 UTC) #4 
Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18213)

Powered by Google App Engine
This is Rietveld 408576698