webrtc/modules/video_coding/frame_object.h - Issue 2937243002: Validate references of frames inserted into FrameBuffer2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/frame_object.h

Issue 2937243002: Validate references of frames inserted into FrameBuffer2. (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/frame_object.h

diff --git a/webrtc/modules/video_coding/frame_object.h b/webrtc/modules/video_coding/frame_object.h

index 413cc3391036ac7a68e4c6d27466c1eac736cf6b..0b368ed3360db0f5434edc78d9a7cd918cccf582 100644

--- a/webrtc/modules/video_coding/frame_object.h

+++ b/webrtc/modules/video_coding/frame_object.h

@@ -51,6 +51,8 @@ class FrameObject : public webrtc::VCMEncodedFrame {

uint8_t spatial_layer;

uint32_t timestamp;

+ // TODO(philipel): Add simple modify/access functions to prevent adding to

tommi 2017/06/15 15:42:10 nit: adding too

+ // many |references|.

size_t num_references;

uint16_t references[kMaxFrameReferences];

bool inter_layer_predicted;