DescriptionWebUI: Replace vulcanize with polymer-bundler.
Summary of changes needed for the migration:
- Excluded URLs behavior is different than Vulcanize, need to explicitly list
all URLs to be excluded (unlike Vulcanize, transitive deps of an excluded
URL are not implicitly excluded).
- Excluded URLs need to match exactly, unlike Vulcanize where foo.html would
match chrome://some-path/foo.html.
- Input HTML files need to have
<html><head>...</head><body>...</body></html> tags.
- A single invocation of poylmer-bundler produces both "basic" and
"lazy" modules (achieved by using the --shell flag), unlike Vulcanize
which required two separate invocations.
- Using new --manifest-out instead of previous --out-request-list flag to
generate depfiles for Ninja.
- Using --rewrite-urls-in-templates to preserve previous rewriting behavior.
- polymer-bundler does not blow up when it can't find a file (unlike Vulcanize,
so check output manifest for any reported "missing" dependencies).
- Removed some Windows specific hacks that don't seem necessary anymore.
BUG=731881
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2936333002
Cr-Commit-Position: refs/heads/master@{#488821}
Committed: https://chromium.googlesource.com/chromium/src/+/1e6a87f5d3ae459cb14031af36c340349eaff40b
Patch Set 1 #Patch Set 2 : Add vulcanize_gn.py changes #Patch Set 3 : Invoke polymer-bundler once, not there yet, but close. #Patch Set 4 : replace strings on disk #Patch Set 5 : Remove reference to main module. #Patch Set 6 : Update depfile generation #Patch Set 7 : Update to polymer-bundler 2.2.0 #Patch Set 8 : Fix bookmarks. #Patch Set 9 : by-vulcanize, by-polymer-bundler #Patch Set 10 : Update NPM dependencies. #Patch Set 11 : Remove strings.js #Patch Set 12 : Fix wrong return. #Patch Set 13 : update polymer bundler #
Total comments: 12
Patch Set 14 : Address comments. #Messages
Total messages: 71 (58 generated)
|