Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: webrtc/api/audio_codecs/audio_encoder_factory_template.h

Issue 2935643002: Templated AudioEncoderFactory (Closed)
Patch Set: better docs Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/audio_codecs/BUILD.gn ('k') | webrtc/api/audio_codecs/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/audio_codecs/audio_encoder_factory_template.h
diff --git a/webrtc/api/audio_codecs/audio_encoder_factory_template.h b/webrtc/api/audio_codecs/audio_encoder_factory_template.h
new file mode 100644
index 0000000000000000000000000000000000000000..a5d5c309a8cc7fd4b057637a35a2e25c2e791619
--- /dev/null
+++ b/webrtc/api/audio_codecs/audio_encoder_factory_template.h
@@ -0,0 +1,142 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_API_AUDIO_CODECS_AUDIO_ENCODER_FACTORY_TEMPLATE_H_
+#define WEBRTC_API_AUDIO_CODECS_AUDIO_ENCODER_FACTORY_TEMPLATE_H_
+
+#include <memory>
+#include <vector>
+
+#include "webrtc/api/audio_codecs/audio_encoder_factory.h"
+#include "webrtc/base/scoped_ref_ptr.h"
+
+namespace webrtc {
+
+namespace audio_encoder_factory_template_impl {
+
+template <typename... Ts>
+struct Helper;
+
+// Base case: 0 template parameters.
+template <>
+struct Helper<> {
+ static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs) {}
+ static rtc::Optional<AudioCodecInfo> QueryAudioEncoder(
+ const SdpAudioFormat& format) {
+ return rtc::Optional<AudioCodecInfo>();
+ }
+ static std::unique_ptr<AudioEncoder> MakeAudioEncoder(
+ int payload_type,
+ const SdpAudioFormat& format) {
+ return nullptr;
+ }
+};
+
+// Inductive case: Called with n + 1 template parameters; calls subroutines
+// with n template parameters.
+template <typename T, typename... Ts>
+struct Helper<T, Ts...> {
+ static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs) {
+ T::AppendSupportedEncoders(specs);
+ Helper<Ts...>::AppendSupportedEncoders(specs);
+ }
+ static rtc::Optional<AudioCodecInfo> QueryAudioEncoder(
+ const SdpAudioFormat& format) {
+ auto opt_config = T::SdpToConfig(format);
+ return opt_config ? rtc::Optional<AudioCodecInfo>(
+ T::QueryAudioEncoder(*opt_config))
+ : Helper<Ts...>::QueryAudioEncoder(format);
+ }
+ static std::unique_ptr<AudioEncoder> MakeAudioEncoder(
+ int payload_type,
+ const SdpAudioFormat& format) {
+ auto opt_config = T::SdpToConfig(format);
+ if (opt_config) {
+ return T::MakeAudioEncoder(*opt_config, payload_type);
+ } else {
+ return Helper<Ts...>::MakeAudioEncoder(payload_type, format);
+ }
+ }
+};
+
+template <typename... Ts>
+class AudioEncoderFactoryT : public AudioEncoderFactory {
+ public:
+ std::vector<AudioCodecSpec> GetSupportedEncoders() override {
+ std::vector<AudioCodecSpec> specs;
+ Helper<Ts...>::AppendSupportedEncoders(&specs);
+ return specs;
+ }
+
+ rtc::Optional<AudioCodecInfo> QueryAudioEncoder(
+ const SdpAudioFormat& format) override {
+ return Helper<Ts...>::QueryAudioEncoder(format);
+ }
+
+ std::unique_ptr<AudioEncoder> MakeAudioEncoder(
+ int payload_type,
+ const SdpAudioFormat& format) override {
+ return Helper<Ts...>::MakeAudioEncoder(payload_type, format);
+ }
+};
+
+} // namespace audio_encoder_factory_template_impl
+
+// Make an AudioEncoderFactory that can create instances of the given encoders.
+//
+// Each encoder type is given as a template argument to the function; it should
+// be a struct with the following static member functions:
+//
+// // Converts |audio_format| to a ConfigType instance. Returns an empty
+// // optional if |audio_format| doesn't correctly specify an encoder of our
+// // type.
+// rtc::Optional<ConfigType> SdpToConfig(const SdpAudioFormat& audio_format);
+//
+// // Appends zero or more AudioCodecSpecs to the list that will be returned
+// // by AudioEncoderFactory::GetSupportedEncoders().
+// void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs);
+//
+// // Returns information about how this format would be encoded. Used to
+// // implement AudioEncoderFactory::QueryAudioEncoder().
+// AudioCodecInfo QueryAudioEncoder(const ConfigType& config);
+//
+// // Creates an AudioEncoder for the specified format. Used to implement
+// // AudioEncoderFactory::MakeAudioEncoder().
+// std::unique_ptr<AudioEncoder> MakeAudioEncoder(const ConfigType& config,
+// int payload_type);
+//
+// ConfigType should be a type that encapsulates all the settings needed to
+// create an AudioDecoder.
+//
+// Whenever it tries to do something, the new factory will try each of the
+// encoders in the order they were specified in the template argument list,
+// stopping at the first one that claims to be able to do the job.
+//
+// NOTE: This function is still under development and may change without notice.
+//
+// TODO(kwiberg): Point at CreateBuiltinAudioEncoderFactory() for an example of
+// how it is used.
+template <typename... Ts>
+rtc::scoped_refptr<AudioEncoderFactory> CreateAudioEncoderFactory() {
+ // There's no technical reason we couldn't allow zero template parameters,
+ // but such a factory couldn't create any encoders, and callers can do this
+ // by mistake by simply forgetting the <> altogether. So we forbid it in
+ // order to prevent caller foot-shooting.
+ static_assert(sizeof...(Ts) >= 1,
+ "Caller must give at least one template parameter");
+
+ return rtc::scoped_refptr<AudioEncoderFactory>(
+ new rtc::RefCountedObject<
+ audio_encoder_factory_template_impl::AudioEncoderFactoryT<Ts...>>());
+}
+
+} // namespace webrtc
+
+#endif // WEBRTC_API_AUDIO_CODECS_AUDIO_ENCODER_FACTORY_TEMPLATE_H_
« no previous file with comments | « webrtc/api/audio_codecs/BUILD.gn ('k') | webrtc/api/audio_codecs/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698