Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: webrtc/media/engine/webrtcmediaengine.h

Issue 2934103002: Allow WebRtcMediaEngine to be created from any thread. (Closed)
Patch Set: Adding DCHECK for encoder_factory Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/mediaengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 namespace cricket { 26 namespace cricket {
27 class WebRtcVideoDecoderFactory; 27 class WebRtcVideoDecoderFactory;
28 class WebRtcVideoEncoderFactory; 28 class WebRtcVideoEncoderFactory;
29 } 29 }
30 30
31 namespace cricket { 31 namespace cricket {
32 32
33 class WebRtcMediaEngineFactory { 33 class WebRtcMediaEngineFactory {
34 public: 34 public:
35 // These Create methods may be called on any thread, though the engine is
36 // only expected to be used on one thread, internally called the "worker
37 // thread". This is the thread Init must be called on.
38
35 // TODO(ossu): Backwards-compatible interface. Will be deprecated once the 39 // TODO(ossu): Backwards-compatible interface. Will be deprecated once the
36 // audio decoder factory is fully plumbed and used throughout WebRTC. 40 // audio decoder factory is fully plumbed and used throughout WebRTC.
37 // See: crbug.com/webrtc/6000 41 // See: crbug.com/webrtc/6000
38 static MediaEngineInterface* Create( 42 static MediaEngineInterface* Create(
39 webrtc::AudioDeviceModule* adm, 43 webrtc::AudioDeviceModule* adm,
40 WebRtcVideoEncoderFactory* video_encoder_factory, 44 WebRtcVideoEncoderFactory* video_encoder_factory,
41 WebRtcVideoDecoderFactory* video_decoder_factory); 45 WebRtcVideoDecoderFactory* video_decoder_factory);
42 46
43 // TODO(deadbeef): Change these to return an std::unique_ptr<>, to indicate 47 // TODO(deadbeef): Change these to return an std::unique_ptr<>, to indicate
44 // that the caller owns the returned object. 48 // that the caller owns the returned object.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 const std::vector<webrtc::RtpExtension>& extensions, 92 const std::vector<webrtc::RtpExtension>& extensions,
89 bool (*supported)(const std::string&), 93 bool (*supported)(const std::string&),
90 bool filter_redundant_extensions); 94 bool filter_redundant_extensions);
91 95
92 webrtc::Call::Config::BitrateConfig GetBitrateConfigForCodec( 96 webrtc::Call::Config::BitrateConfig GetBitrateConfigForCodec(
93 const Codec& codec); 97 const Codec& codec);
94 98
95 } // namespace cricket 99 } // namespace cricket
96 100
97 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCMEDIAENGINE_H_ 101 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCMEDIAENGINE_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/mediaengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698