build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 2933993002: Add local results details pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2933993002: Add local results details pages.

Patch Set: Fix some of Johns comments. Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/base/output_manager_factory.py ('k') | build/android/pylib/local/device/local_device_environment.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 42ae4422466e425c30dd37f17df3eeff1c7db979..ecd3e0f6078efd669bedbcdd64345531da389b84 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -498,7 +498,6 @@ class InstrumentationTestInstance(test_instance.TestInstance):

self._initializeTombstonesAttributes(args)

self._gs_results_bucket = None

- self._should_save_logcat = None

self._initializeLogAttributes(args)

self._edit_shared_prefs = []

@@ -684,7 +683,6 @@ class InstrumentationTestInstance(test_instance.TestInstance):

def _initializeLogAttributes(self, args):

self._gs_results_bucket = args.gs_results_bucket

- self._should_save_logcat = bool(args.json_results_file)

def _initializeEditPrefsAttributes(self, args):

if not hasattr(args, 'shared_prefs_file') or not args.shared_prefs_file:

@@ -753,10 +751,6 @@ class InstrumentationTestInstance(test_instance.TestInstance):

def junit4_runner_class(self):

return self._junit4_runner_class

- @property

- def should_save_logcat(self):

- return self._should_save_logcat

@property

def package_info(self):

return self._package_info

« no previous file with comments | « build/android/pylib/base/output_manager_factory.py ('k') | build/android/pylib/local/device/local_device_environment.py » ('j') | no next file with comments »