android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java - Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest (Closed)

Patch Set: address bo's comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwTestCommon.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java » ('j') | android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

index 8e39f2e63c84189b3a68b3f7a3213cd29bb4dbb0..1aa25a7e8fa2bd2951ad94e41da041ea7f68b8af 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

@@ -264,7 +264,7 @@ public class ClientOnPageFinishedTest extends AwTestBase {

int onPageFinishedCallCount = onPageFinishedHelper.getCallCount();

int onPageStartedCallCount = onPageStartedHelper.getCallCount();

- JSUtils.clickOnLinkUsingJs(this, mAwContents,

+ JSUtils.clickOnLinkUsingJs(getInstrumentation(), mAwContents,

mContentsClient.getOnEvaluateJavaScriptResultHelper(), "link");

onPageFinishedHelper.waitForCallback(onPageFinishedCallCount);