android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java - Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

Issue 2933623002: Create AwJUnit4ClassRunner AwActivityTestRule and convert AwContentsTest (Closed)

Patch Set: address bo's comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwActivityTestRule.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java » ('j') | android_webview/test/shell/src/org/chromium/android_webview/test/AwJUnit4ClassRunner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

index 5e3004e20ba67980814db112f0148e3ba9749568..f56533f1bb3dbf7b0baae92a341a86b26ac708ee 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

@@ -214,7 +214,7 @@ public class AwContentsClientShouldInterceptRequestTest extends AwTestBase {

mShouldInterceptRequestHelper.getRequestsForUrl(pageWithFormUrl).method);

callCount = mShouldInterceptRequestHelper.getCallCount();

- JSUtils.clickOnLinkUsingJs(this, mAwContents,

+ JSUtils.clickOnLinkUsingJs(getInstrumentation(), mAwContents,

mContentsClient.getOnEvaluateJavaScriptResultHelper(), "link");

mShouldInterceptRequestHelper.waitForCallback(callCount);

assertEquals("POST",