Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2933453002: Always use DirectCompositionSurfaceWin when using DirectComposition (Closed)

Created:
3 years, 6 months ago by jbauman
Modified:
3 years, 5 months ago
Reviewers:
kenrb, sunnyps
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use DirectCompositionSurfaceWin when using DirectComposition ChildWindowSurfaceWin was using DirectComposition internally inside ANGLE. We can get rid of it and use DirectCompositionSurfaceWin everywhere instead, because by default that just does the same thing except explicitly inside Chrome. Doing this saves code and allows us to switch backbuffers between having alpha and not having alpha without flickering (because the SwapChain can be recreated but the DirectComposition device can be kept around). A new context capability (use_overlays_for_video) is added to determine whether it's more efficient to promote videos to use overlays. This was originally determined using the dc_layers capability. BUG=722107 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2933453002 Cr-Commit-Position: refs/heads/master@{#489467} Committed: https://chromium.googlesource.com/chromium/src/+/ac13d8266c1e18429a0584b780e7daa5bcf1542e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove include #

Total comments: 3

Patch Set 4 : post-review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -250 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/ipc/service/child_window_surface_win.h View 1 chunk +0 lines, -46 lines 0 comments Download
D gpu/ipc/service/child_window_surface_win.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 2 3 2 chunks +17 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_init.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/image_transport_surface_win.cc View 1 2 3 2 chunks +6 lines, -21 lines 0 comments Download
M ui/gl/gl_surface.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (25 generated)
jbauman
3 years, 5 months ago (2017-07-24 19:57:06 UTC) #17
sunnyps
lgtm https://codereview.chromium.org/2933453002/diff/40001/gpu/command_buffer/common/capabilities.h File gpu/command_buffer/common/capabilities.h (right): https://codereview.chromium.org/2933453002/diff/40001/gpu/command_buffer/common/capabilities.h#newcode162 gpu/command_buffer/common/capabilities.h:162: bool use_overlays_for_video = false; nit: If this is ...
3 years, 5 months ago (2017-07-24 22:03:47 UTC) #18
jbauman
kenrb@: SECURITY_OWNERS review of a new flag on an IPC.
3 years, 5 months ago (2017-07-25 20:48:01 UTC) #24
kenrb
ipc lgtm
3 years, 5 months ago (2017-07-25 21:06:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933453002/60001
3 years, 5 months ago (2017-07-25 22:30:28 UTC) #28
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 22:36:42 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ac13d8266c1e18429a0584b780e7...

Powered by Google App Engine
This is Rietveld 408576698