Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)
Patch Set: fix_for_unittest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/send_side_congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc
index d5f966aeaa7818d721c53aef4e6caf2f50121b1d..ce6b96b0b4c430f1cb3afe8ce98257bd8104c4f9 100644
--- a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc
@@ -20,7 +20,7 @@
#include "webrtc/base/rate_limiter.h"
#include "webrtc/base/socket.h"
#include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
-#include "webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h"
+#include "webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h"
#include "webrtc/modules/congestion_controller/probe_controller.h"
#include "webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h"
@@ -89,7 +89,8 @@ SendSideCongestionController::SendSideCongestionController(
bitrate_controller_(
BitrateController::CreateBitrateController(clock_, event_log)),
acknowledged_bitrate_estimator_(
- rtc::MakeUnique<AcknowledgedBitrateEstimator>()),
+ rtc::MakeUnique<AcknowledgedBitrateEstimator>(
+ rtc::MakeUnique<BitrateEstimatorCreator>())),
probe_controller_(new ProbeController(pacer_.get(), clock_)),
retransmission_rate_limiter_(
new RateLimiter(clock, kRetransmitWindowSizeMs)),
@@ -278,7 +279,8 @@ void SendSideCongestionController::OnTransportFeedback(
transport_feedback_adapter_.GetTransportFeedbackVector());
SortPacketFeedbackVector(&feedback_vector);
acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(
- feedback_vector);
+ feedback_vector,
+ static_cast<bool>(pacer_->GetApplicationLimitedRegionStartTime()));
DelayBasedBwe::Result result;
{
rtc::CritScope cs(&bwe_lock_);

Powered by Google App Engine
This is Rietveld 408576698