Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)
Patch Set: fix_for_unittest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h
diff --git a/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h b/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h
new file mode 100644
index 0000000000000000000000000000000000000000..afed1dcac0368f415ac6659da31f76d38e5e9d63
--- /dev/null
+++ b/webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h
@@ -0,0 +1,55 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_
+#define WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_
+
+#include <memory>
+#include <vector>
+
+#include "webrtc/base/optional.h"
+#include "webrtc/modules/congestion_controller/bitrate_estimator.h"
+
+namespace webrtc {
+
+struct PacketFeedback;
+
+class BitrateEstimatorCreator {
+ public:
+ virtual ~BitrateEstimatorCreator() = default;
+ virtual std::unique_ptr<BitrateEstimator> Create();
+};
+
+class AcknowledgedBitrateEstimator {
+ public:
+ explicit AcknowledgedBitrateEstimator(
+ std::unique_ptr<BitrateEstimatorCreator> bitrate_estimator_creator);
+
+ AcknowledgedBitrateEstimator();
+
+ void IncomingPacketFeedbackVector(
+ const std::vector<PacketFeedback>& packet_feedback_vector,
+ bool currently_in_alr);
+ rtc::Optional<uint32_t> bitrate_bps() const;
+
+ private:
+ bool SentBeforeAlrEnded(const PacketFeedback& packet);
+ bool AlrEnded(bool currently_in_alr) const;
+ void MaybeResetBitrateEstimator(bool currently_in_alr);
+
+ bool was_in_alr_;
+ rtc::Optional<int64_t> alr_ended_time_ms_;
+ const std::unique_ptr<BitrateEstimatorCreator> bitrate_estimator_creator_;
+ std::unique_ptr<BitrateEstimator> bitrate_estimator_;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_

Powered by Google App Engine
This is Rietveld 408576698