webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 2931873002: Test and fix for huge bwe drop after alr state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)

Patch Set: Response to comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/acknowledged_bitrate_estimator_unittest.cc ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index 290f0cb125efdc49a1b9851e41047239d25fb968..9c8f3192fb39d7843024a7946a519b0022c9292b 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -31,7 +31,8 @@ SendSideBweSender::SendSideBweSender(int kbps,

observer,

&event_log_)),

acknowledged_bitrate_estimator_(

- rtc::MakeUnique<AcknowledgedBitrateEstimator>()),

+ rtc::MakeUnique<AcknowledgedBitrateEstimator>(

+ rtc::MakeUnique<BitrateEstimatorCreator>())),

bwe_(new DelayBasedBwe(nullptr, clock)),

feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),

clock_(clock),

@@ -76,7 +77,7 @@ void SendSideBweSender::GiveFeedback(const FeedbackPacket& feedback) {

BWE_TEST_LOGGING_PLOT(1, "RTT", clock_->TimeInMilliseconds(), rtt_ms);

acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(

- packet_feedback_vector);

+ packet_feedback_vector, false);

DelayBasedBwe::Result result = bwe_->IncomingPacketFeedbackVector(

packet_feedback_vector, acknowledged_bitrate_estimator_->bitrate_bps());

if (result.updated)