webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc - Issue 2931873002: Test and fix for huge bwe drop after alr state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)

Patch Set: Response to comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/acknowledged_bitrate_estimator_unittest.cc ('K') | « webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h ('k') | webrtc/modules/congestion_controller/send_side_congestion_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

index 62c9f881bc1ef1e92213efc871e6013bc2eddc6c..9b42364cfbe0d31bdada28fdfad0c6ea4c8de5dd 100644

--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc

@@ -151,7 +151,8 @@ int64_t StreamGenerator::GenerateFrame(std::vector<PacketFeedback>* packets,

DelayBasedBweTest::DelayBasedBweTest()

: clock_(100000000),

acknowledged_bitrate_estimator_(

- rtc::MakeUnique<AcknowledgedBitrateEstimator>()),

+ rtc::MakeUnique<AcknowledgedBitrateEstimator>(

+ rtc::MakeUnique<BitrateEstimatorCreator>())),

bitrate_estimator_(new DelayBasedBwe(nullptr, &clock_)),

stream_generator_(new test::StreamGenerator(1e6, // Capacity.

clock_.TimeInMicroseconds())),

@@ -184,7 +185,7 @@ void DelayBasedBweTest::IncomingFeedback(int64_t arrival_time_ms,

sequence_number, payload_size, pacing_info);

std::vector<PacketFeedback> packets;

packets.push_back(packet);

- acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(packets);

+ acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(packets, false);

DelayBasedBwe::Result result =

bitrate_estimator_->IncomingPacketFeedbackVector(

packets, acknowledged_bitrate_estimator_->bitrate_bps());

@@ -219,7 +220,7 @@ bool DelayBasedBweTest::GenerateAndProcessFrame(uint32_t ssrc,

packet.arrival_time_ms += arrival_time_offset_ms_;

}

- acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(packets);

+ acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(packets, false);

DelayBasedBwe::Result result =

bitrate_estimator_->IncomingPacketFeedbackVector(

packets, acknowledged_bitrate_estimator_->bitrate_bps());