webrtc/modules/congestion_controller/send_side_congestion_controller.cc - Issue 2931873002: Test and fix for huge bwe drop after alr state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/bitrate_estimator.h ('K') | « webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/send_side_congestion_controller.cc

diff --git a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

index 57e7685f88f52362de74e20ac300c41a09aa5c79..4833c8808b6a3a3a0207145670a54f41f80c5f33 100644

--- a/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

+++ b/webrtc/modules/congestion_controller/send_side_congestion_controller.cc

@@ -279,7 +279,8 @@ void SendSideCongestionController::OnTransportFeedback(

transport_feedback_adapter_.GetTransportFeedbackVector());

SortPacketFeedbackVector(&feedback_vector);

acknowledged_bitrate_estimator_->IncomingPacketFeedbackVector(

- feedback_vector);

+ feedback_vector,

+ static_cast<bool>(pacer_->GetApplicationLimitedRegionStartTime()));

minyue-webrtc 2017/06/12 10:08:07 no need for explicit cast

tschumi 2017/06/12 11:33:28 It seams its needed, the compiler don't do a impli

DelayBasedBwe::Result result;

{

rtc::CritScope cs(&bwe_lock_);