Test and fix for huge bwe drop after alr state.

webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_
+#define WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_
+
+#include <memory>
+#include <vector>
+
+#include "webrtc/base/optional.h"
+#include "webrtc/modules/congestion_controller/bitrate_estimator.h"
+
+namespace webrtc {
+
+struct PacketFeedback;
+
+class BitrateEstimatorCreator {
+ public:
+  virtual ~BitrateEstimatorCreator() = default;
+  virtual std::unique_ptr<BitrateEstimator> Create() const;
+};
+
+class AcknowledgedBitrateEstimator {
+ public:
+  AcknowledgedBitrateEstimator(
+      std::unique_ptr<BitrateEstimatorCreator> bitrate_estimator_creator);
+
+  void IncomingPacketFeedbackVector(
+      const std::vector<PacketFeedback>& packet_feedback_vector,
+      bool alr_state);
+  rtc::Optional<uint32_t> bitrate_bps() const;
+
+ private:
+  bool SentBeforLeftAlr(const PacketFeedback& packet);

[holmer, 2017/06/12 11:45:14]

SentBeforeLeftAlr

What does left alr mean?

[tschumi, 2017/06/12 11:53:04]

The the function should return true when we left alr state and the packet we
give to it was sent while we still where in alr state. :)

I was not bale to come up with a good name till now.

[stefan-webrtc, 2017/06/12 12:17:23]

Maybe split in two and make this:
if (SentInAlrState(packet) && HasLeftAlrState(alr_state))...

[tschumi, 2017/06/12 14:14:15]

I tried to impl. this but the results where kind of silly. So I decided to go
for "SentInAlrState".
I hope everyone can live with that.
 

+  bool HasLeftAlrState(bool alr_state) const;
+  void MaybeResetBitrateEstimator(bool alr_state);
+
+  bool last_alr_state_;
+  rtc::Optional<int64_t> left_alr_state_ms_;
+  const std::unique_ptr<BitrateEstimatorCreator> bitrate_estimator_creator_;
+  std::unique_ptr<BitrateEstimator> bitrate_estimator_;
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGED_BITRATE_ESTIMATOR_H_