Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2272)

Side by Side Diff: webrtc/audio/test/low_bandwidth_audio_test.h

Issue 2931873002: Test and fix for huge bwe drop after alr state. (Closed)
Patch Set: Respons to comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/audio/test/low_bandwidth_audio_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #ifndef WEBRTC_AUDIO_TEST_LOW_BANDWIDTH_AUDIO_TEST_H_ 10 #ifndef WEBRTC_AUDIO_TEST_LOW_BANDWIDTH_AUDIO_TEST_H_
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 test::PacketTransport* CreateSendTransport(Call* sender_call) override; 44 test::PacketTransport* CreateSendTransport(Call* sender_call) override;
45 test::PacketTransport* CreateReceiveTransport() override; 45 test::PacketTransport* CreateReceiveTransport() override;
46 46
47 void ModifyAudioConfigs( 47 void ModifyAudioConfigs(
48 AudioSendStream::Config* send_config, 48 AudioSendStream::Config* send_config,
49 std::vector<AudioReceiveStream::Config>* receive_configs) override; 49 std::vector<AudioReceiveStream::Config>* receive_configs) override;
50 50
51 void PerformTest() override; 51 void PerformTest() override;
52 void OnTestFinished() override; 52 void OnTestFinished() override;
53 53
54 Call* sender_call_;
holmer 2017/06/19 08:53:49 AFAICT this can still be private?
tschumi 2017/06/19 10:36:03 I think i could move it in to the NoBandwidthDropA
holmer 2017/06/19 11:51:53 Ok, maybe worth doing? Or protected is enough?
tschumi 2017/06/19 12:08:48 Ok moved sender_call_ to NoBandwidthDropAfterDtx.
55
54 private: 56 private:
55 test::FakeAudioDevice* send_audio_device_; 57 test::FakeAudioDevice* send_audio_device_;
56 }; 58 };
57 59
58 } // namespace test 60 } // namespace test
59 } // namespace webrtc 61 } // namespace webrtc
60 62
61 #endif // WEBRTC_AUDIO_TEST_LOW_BANDWIDTH_AUDIO_TEST_H_ 63 #endif // WEBRTC_AUDIO_TEST_LOW_BANDWIDTH_AUDIO_TEST_H_
OLDNEW
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/audio/test/low_bandwidth_audio_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698