Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2950)

Unified Diff: ash/system/tray/system_tray.cc

Issue 2930123002: Tablet WM : Swiping on system tray bubble. (Closed)
Patch Set: Fixed comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/system_tray.h ('k') | ash/system/tray/system_tray_bubble.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/system_tray.cc
diff --git a/ash/system/tray/system_tray.cc b/ash/system/tray/system_tray.cc
index 35798e8ca0443a3f23b8fd3019fece0153b88c3e..2d8c73dcec44bc8c183944adfaf0ffc9e801dc4d 100644
--- a/ash/system/tray/system_tray.cc
+++ b/ash/system/tray/system_tray.cc
@@ -51,6 +51,7 @@
#include "ash/system/user/tray_user.h"
#include "ash/system/web_notification/web_notification_tray.h"
#include "ash/wm/container_finder.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
#include "ash/wm/widget_finder.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
@@ -173,8 +174,10 @@ class SystemTray::ActivationObserver : public ::wm::ActivationChangeObserver {
int container_id = wm::GetContainerForWindow(gained_active)->id();
// Don't close the bubble if a popup notification is activated.
- if (container_id == kShellWindowId_StatusContainer)
+ if (container_id == kShellWindowId_StatusContainer ||
+ container_id == kShellWindowId_SettingBubbleContainer) {
return;
+ }
views::Widget* bubble_widget =
tray_->GetSystemBubble()->bubble_view()->GetWidget();
@@ -199,7 +202,8 @@ class SystemTray::ActivationObserver : public ::wm::ActivationChangeObserver {
// SystemTray
-SystemTray::SystemTray(Shelf* shelf) : TrayBackgroundView(shelf) {
+SystemTray::SystemTray(Shelf* shelf)
+ : TrayBackgroundView(shelf), shelf_(shelf) {
SetInkDropMode(InkDropMode::ON);
// Since user avatar is on the right hand side of System tray of a
@@ -632,6 +636,21 @@ void SystemTray::ActivateBubble() {
bubble_view->GetWidget()->Activate();
}
+void SystemTray::OnGestureEvent(ui::GestureEvent* event) {
+ if (Shell::Get()
+ ->maximize_mode_controller()
+ ->IsMaximizeModeWindowManagerEnabled() &&
+ shelf_->IsHorizontalAlignment() && ProcessGestureEvent(*event)) {
+ event->SetHandled();
+ } else {
+ TrayBackgroundView::OnGestureEvent(event);
+ }
+}
+
+gfx::Rect SystemTray::GetWorkAreaBoundsInScreen() const {
+ return shelf_->GetUserWorkAreaBounds();
+}
+
bool SystemTray::PerformAction(const ui::Event& event) {
// If we're already showing a full system tray menu, either default or
// detailed menu, hide it; otherwise, show it (and hide any popup that's
@@ -646,6 +665,96 @@ bool SystemTray::PerformAction(const ui::Event& event) {
return true;
}
+bool SystemTray::ProcessGestureEvent(const ui::GestureEvent& event) {
+ if (event.type() == ui::ET_GESTURE_SCROLL_BEGIN)
+ return StartGestureDrag(event);
+
+ if (!HasSystemBubble() || !is_in_drag_)
+ return false;
+
+ if (event.type() == ui::ET_GESTURE_SCROLL_UPDATE) {
+ UpdateGestureDrag(event);
+ return true;
+ }
+
+ if (event.type() == ui::ET_GESTURE_SCROLL_END ||
+ event.type() == ui::ET_SCROLL_FLING_START) {
+ CompleteGestureDrag(event);
+ return true;
+ }
+
+ // Unexpected event. Reset the drag state and close the bubble.
+ is_in_drag_ = false;
+ CloseSystemBubble();
+ return false;
+}
+
+bool SystemTray::StartGestureDrag(const ui::GestureEvent& gesture) {
+ // Close the system bubble if there is already a full one opened. And return
+ // false to let shelf handle the event.
+ if (HasSystemBubble() && full_system_tray_menu_) {
+ system_bubble_->bubble()->Close();
+ return false;
+ }
+
+ // If the scroll sequence begins to scroll downward, return false so that the
+ // event will instead by handled by the shelf.
+ if (gesture.details().scroll_y_hint() > 0)
+ return false;
+
+ is_in_drag_ = true;
+ gesture_drag_amount_ = 0.f;
+ ShowDefaultView(BUBBLE_CREATE_NEW);
+ system_tray_bubble_bounds_ =
+ system_bubble_->bubble_view()->GetWidget()->GetWindowBoundsInScreen();
+ SetBubbleBounds(gesture.location());
+ return true;
+}
+
+void SystemTray::UpdateGestureDrag(const ui::GestureEvent& gesture) {
+ SetBubbleBounds(gesture.location());
+ gesture_drag_amount_ += gesture.details().scroll_y();
+}
+
+void SystemTray::CompleteGestureDrag(const ui::GestureEvent& gesture) {
+ const bool hide_bubble = !ShouldShowSystemBubbleAfterScrollSequence(gesture);
+ gfx::Rect target_bounds = system_tray_bubble_bounds_;
+
+ if (hide_bubble)
+ target_bounds.set_y(shelf_->GetIdealBounds().y());
+
+ system_bubble_->bubble()->AnimateToTargetBounds(target_bounds, hide_bubble);
+ is_in_drag_ = false;
+}
+
+void SystemTray::SetBubbleBounds(const gfx::Point& location) {
+ gfx::Point location_in_screen_coordinates(location);
+ View::ConvertPointToScreen(this, &location_in_screen_coordinates);
+
+ // System tray bubble should not be dragged higher than its original height.
+ if (location_in_screen_coordinates.y() < system_tray_bubble_bounds_.y())
+ location_in_screen_coordinates.set_y(system_tray_bubble_bounds_.y());
+
+ gfx::Rect bounds_on_location = system_tray_bubble_bounds_;
+ bounds_on_location.set_y(location_in_screen_coordinates.y());
+ system_bubble_->bubble_view()->GetWidget()->SetBounds(bounds_on_location);
+}
+
+bool SystemTray::ShouldShowSystemBubbleAfterScrollSequence(
+ const ui::GestureEvent& sequence_end) {
+ // If the scroll sequence terminates with a fling, show the system menu if the
+ // fling was fast enough and in the correct direction.
+ if (sequence_end.type() == ui::ET_SCROLL_FLING_START &&
+ fabs(sequence_end.details().velocity_y()) > kFlingVelocity) {
+ return sequence_end.details().velocity_y() < 0;
+ }
+
+ DCHECK(sequence_end.type() == ui::ET_GESTURE_SCROLL_END ||
+ sequence_end.type() == ui::ET_SCROLL_FLING_START);
+ // Show the system menu if it is already at least one-third visible.
+ return -gesture_drag_amount_ >= system_tray_bubble_bounds_.height() / 3.0;
+}
+
void SystemTray::CloseSystemBubbleAndDeactivateSystemTray() {
activation_observer_.reset();
key_event_watcher_.reset();
« no previous file with comments | « ash/system/tray/system_tray.h ('k') | ash/system/tray/system_tray_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698