Return WrappedI444Buffer in VP9Impl

webrtc/common_video/include/video_frame_buffer.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 63 matching lines @@
   const int height_;
   const uint8_t* const y_plane_;
   const uint8_t* const u_plane_;
   const uint8_t* const v_plane_;
   const int y_stride_;
   const int u_stride_;
   const int v_stride_;
   rtc::Callback0<void> no_longer_used_cb_;
 };
 
+class WrappedI444Buffer : public I444BufferInterface {

[Yuwei, 2017/06/08 20:38:37]

TBH I don't quite like duplicating the WrappedI420Buffer class but I couldn't
think of better way to work with the I444BufferInterface...

[nisse-webrtc, 2017/06/09 09:01:22]

I think it should be doable to define WrappedYuvBuffer as a template,
parameterized by the desired interface class (and hence indirectly by the type
enum). So we could define

  using WrappedI420Buffer = WrappedYuvBuffer<I420BufferInterface>;

  using WrappedI444Buffer = WrappedYuvBuffer<I444BufferInterface>;

Not sure if it's worth the extra complexity, though?

[magjed_webrtc, 2017/06/09 13:46:57]

How about we expose two factory functions instead:
rtc::scoped_refptr<I420BufferInterface> WrapI420(int width, int height, ...);
rtc::scoped_refptr<I444BufferInterface> WrapI444(int width, int height, ...);
and do the template implementation in the .cc file? I don't want to expose the
template implementation here, but I'm fine with doing it in the .cc file.

[Yuwei, 2017/06/10 00:13:52]

Done. This is much better :) But please also see the comment below.

+ public:
+  WrappedI444Buffer(int width,
+                    int height,
+                    const uint8_t* y_plane,
+                    int y_stride,
+                    const uint8_t* u_plane,
+                    int u_stride,
+                    const uint8_t* v_plane,
+                    int v_stride,
+                    const rtc::Callback0<void>& no_longer_used);
+  int width() const override;
+  int height() const override;
+
+  const uint8_t* DataY() const override;
+  const uint8_t* DataU() const override;
+  const uint8_t* DataV() const override;
+  int StrideY() const override;
+  int StrideU() const override;
+  int StrideV() const override;
+
+ private:
+  friend class rtc::RefCountedObject<WrappedI444Buffer>;
+  ~WrappedI444Buffer() override;
+
+  const int width_;
+  const int height_;
+  const uint8_t* const y_plane_;
+  const uint8_t* const u_plane_;
+  const uint8_t* const v_plane_;
+  const int y_stride_;
+  const int u_stride_;
+  const int v_stride_;
+  rtc::Callback0<void> no_longer_used_cb_;
+};
+
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_VIDEO_INCLUDE_VIDEO_FRAME_BUFFER_H_