Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h

Issue 2924993002: Move temporal-layer properties to FrameConfig. (Closed)
Patch Set: remove timestamp check, input frame doesn't repeat Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
index 9b122919380684bf651d35fc7753bda93496c976..13aca8f3741f09570d5de31e6cd5a19c4d1b91d5 100644
--- a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
+++ b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
@@ -47,13 +47,12 @@ class TemporalLayers {
BufferFlags golden_buffer_flags;
BufferFlags arf_buffer_flags;
- // TODO(pbos): Consider breaking these out of here and returning only a
- // pattern index that needs to be returned to fill CodecSpecificInfoVP8 or
- // EncodeFlags.
+ int encoder_layer_id;
+ int packetizer_temporal_idx;
sprang_webrtc 2017/06/13 11:39:22 Please add a comment explaining what the differenc
pbos-webrtc 2017/06/15 21:59:09 Done.
+
bool layer_sync;
- bool freeze_entropy;
- int pattern_idx;
+ bool freeze_entropy;
private:
FrameConfig(BufferFlags last,
@@ -91,8 +90,6 @@ class TemporalLayers {
// Returns the current tl0_pic_idx, so it can be reused in future
// instantiations.
virtual uint8_t Tl0PicIdx() const = 0;
- virtual int GetTemporalLayerId(
- const TemporalLayers::FrameConfig& tl_config) const = 0;
};
class TemporalLayersListener;

Powered by Google App Engine
This is Rietveld 408576698