webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc - Issue 2924993002: Move temporal-layer properties to FrameConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Issue 2924993002: Move temporal-layer properties to FrameConfig. (Closed)

Patch Set: improve unittests Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc ('k') | webrtc/modules/video_coding/codecs/vp8/temporal_layers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

index 02674ecd7c38cede4e12ea23273dcc03364375a1..8335bb9ec113a303fe1ad9ea7c68c5e4ca67aa26 100644

--- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

@@ -71,6 +71,10 @@ class ScreenshareLayerTest : public ::testing::Test {

int ConfigureFrame(bool key_frame) {

tl_config_ = layers_->UpdateLayerConfig(timestamp_);

+ EXPECT_EQ(0, tl_config_.encoder_layer_id)

+ << "ScreenshareLayers always encodes using the bitrate allocator for "

+ "layer 0, but may reference different buffers and packetize "

+ "differently.";

if (tl_config_.drop_frame) {

return -1;

}