Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h

Issue 2924603002: Added implementation of four functions in the BBR congestion controller. (Closed)
Patch Set: Added some comments and declaration of two functions. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h b/webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h
index ebb2e6e5eea2ac6a65c516e2e09504823af79a19..eb28eec65713bd516b50323305e481d9489b57b4 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h
@@ -30,7 +30,7 @@ class MinRttFilter;
class CongestionWindow;
class BbrBweSender : public BweSender {
public:
- BbrBweSender();
+ explicit BbrBweSender(Clock* clock);
virtual ~BbrBweSender();
enum Mode {
// Startup phase.
@@ -64,8 +64,21 @@ class BbrBweSender : public BweSender {
void TryExitingDrain(int64_t now);
void EnterProbeBw(int64_t now);
void EnterProbeRtt(int64_t now);
- void TryExitingProbeRtt(int64_t now);
void TryUpdatingCyclePhase(int64_t now);
+ void TryEnteringProbeRtt(int64_t now);
+ void TryExitingProbeRtt(int64_t now);
+ Clock* const clock_;
+ Mode mode_;
+ std::unique_ptr<MaxBandwidthFilter> max_bandwidth_filter_;
+ uint64_t round_count_;
+ uint64_t last_packet_sent_;
+ uint64_t round_trip_end_;
+ float pacing_gain_;
+ float congestion_window_gain_;
+
+ // If optimal bandwidth has been discovered and reached,
philipel 2017/06/07 11:34:31 Use the full 80 char limit for comments.
gnish1 2017/06/07 12:30:14 Done.
+ // (for example after Startup mode) set this variable to true.
+ bool full_bandwidth_reached_;
};
class BbrBweReceiver : public BweReceiver {

Powered by Google App Engine
This is Rietveld 408576698