Added implementation of four functions in the BBR congestion controller.

webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
 
 #include "webrtc/modules/remote_bitrate_estimator/test/estimators/bbr.h"
 
 #include <time.h>
 #include <algorithm>
 #include <utility>
 
 #include "webrtc/base/logging.h"
 #include "webrtc/modules/congestion_controller/delay_based_bwe.h"
 #include "webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"
+#include "webrtc/modules/remote_bitrate_estimator/test/estimators/max_bandwidth_filter.h"
 
 namespace webrtc {
 namespace testing {
 namespace bwe {
-BbrBweSender::BbrBweSender() : BweSender() {
+namespace {
+const int kFeedbackIntervalsMs = 100;
+const float kHighGain = 2.885;

[philipel, 2017/06/05 15:04:51]

Comment where you got these values from.

[gnish1, 2017/06/07 07:52:00]

Done.

+const float kDrainGain = 1 / kHighGain;
+const float kStartupGrowthTarget = 1.25;
+const int kMaxRoundsWithoutGrowth = 3;
+}  //
+BbrBweSender::BbrBweSender(Clock* clock)
+    : BweSender(0),
+      clock_(clock),
+      mode_(STARTUP),
+      max_bandwidth_filter_(),
+      rt_count_(0),
+      last_packet_sent_(0),
+      round_trip_end_(0),
+      full_bandwidth_reached_(false) {
   // Initially enter Startup mode.
   EnterStartup();
 }
 
 BbrBweSender::~BbrBweSender() {}
 
 int BbrBweSender::GetFeedbackIntervalMs() const {
-  return 0;
+  return kFeedbackIntervalsMs;
 }
 
-void BbrBweSender::GiveFeedback(const FeedbackPacket& feedback) {}
+void BbrBweSender::GiveFeedback(const FeedbackPacket& feedback) {
+  const BbrBweFeedback& fb = static_cast<const BbrBweFeedback&>(feedback);
+  const std::vector<std::pair<uint64_t, int64_t>>& feedback_vector =
+      fb.packet_feedback_vector();
+  // Check if new round started for the connection.

[philipel, 2017/06/05 15:04:51]

Don't split comments into unnecessarily many lines, use the 80 char limit

[gnish1, 2017/06/07 07:52:00]

Done.

+  // Round is the period of time from sending packet
+  // to its acknowledgement.
+  bool new_round_started = false;
+  if (!feedback_vector.empty()) {
+    uint64_t last_acked_packet = feedback_vector.rbegin()->first;
+    if (last_acked_packet > round_trip_end_) {
+      new_round_started = true;
+      rt_count_++;
+      round_trip_end_ = last_packet_sent_;
+    }
+  }
+  if (new_round_started && !full_bandwidth_reached_)

[philipel, 2017/06/05 15:04:50]

When the if statement or the following expression is more than one line use {}

[gnish1, 2017/06/07 07:52:00]

Done.

+    full_bandwidth_reached_ = max_bandwidth_filter_->FullBandwidthReached(
+        kStartupGrowthTarget, kMaxRoundsWithoutGrowth);
+  int now = clock_->TimeInMilliseconds();
+  switch (mode_) {
+    break;
+    case STARTUP:
+      TryExitingStartup();
+      break;
+    case DRAIN:
+      TryExitingDrain(now);
+      break;
+    case PROBE_BW:
+      TryUpdatingCyclePhase(now);
+      break;
+    case PROBE_RTT:
+      break;
+  }
+  TryEnteringOrExitingProbeRtt(now);

[philipel, 2017/06/05 15:04:51]

Should this function always be called?

[gnish1, 2017/06/07 07:52:00]

Yes,if min_rtt value expired it will start ProbeRtt mode,if our current mode is
ProbeRtt it will try to exit.

[terelius, 2017/06/07 08:14:55]

Is this equivalent to:
  ...
  case PROBE_RTT:
    TryExitProbeRtt();
    break;
}
TryEnterProbeRtt()

+  // TODO(gnish): implement functions updating
+  // congestion window and pacing rate controllers.
+}
 
 bool BbrBweSender::UpdateBandwidthAndMinRtt() {
   return false;
 }
 
-void BbrBweSender::EnterStartup() {}
+void BbrBweSender::EnterStartup() {
+  mode_ = STARTUP;
+  pacing_gain_ = kHighGain;
+  congestion_window_gain_ = kHighGain;
+}
 
-void BbrBweSender::TryExitingStartup() {}
+void BbrBweSender::TryExitingStartup() {
+  if (full_bandwidth_reached_) {
+    mode_ = DRAIN;
+    pacing_gain_ = kDrainGain;
+    congestion_window_gain_ = kHighGain;
+  }
+}
 
 void BbrBweSender::TryExitingDrain(int64_t now) {}
 
 void BbrBweSender::EnterProbeBw(int64_t now) {}
 
 void BbrBweSender::TryUpdatingCyclePhase(int64_t now) {}
 
-void BbrBweSender::EnterProbeRtt(int64_t now) {}
-
-void BbrBweSender::TryExitingProbeRtt(int64_t now) {}
+void BbrBweSender::TryEnteringOrExitingProbeRtt(int64_t now) {}
 
 int64_t BbrBweSender::TimeUntilNextProcess() {
   return 100;
 }
 
-void BbrBweSender::OnPacketsSent(const Packets& packets) {}
+void BbrBweSender::OnPacketsSent(const Packets& packets) {
+  last_packet_sent_ =
+      (static_cast<const MediaPacket*>(packets.back()))->sequence_number();

[philipel, 2017/06/05 15:04:51]

remove one set of () 

[gnish1, 2017/06/07 07:52:00]

Done.

+}
 
 void BbrBweSender::Process() {}
 
 BbrBweReceiver::BbrBweReceiver(int flow_id)
     : BweReceiver(flow_id, kReceivingRateTimeWindowMs),
       clock_(0),
       packet_feedbacks_() {}
 
 BbrBweReceiver::~BbrBweReceiver() {}
 
 void BbrBweReceiver::ReceivePacket(int64_t arrival_time_ms,
                                    const MediaPacket& media_packet) {}
 
 FeedbackPacket* BbrBweReceiver::GetFeedback(int64_t now_ms) {
   return nullptr;
 }
 }  // namespace bwe
 }  // namespace testing
 }  // namespace webrtc