Move MinPositive to call.h

webrtc/call/call.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #ifndef WEBRTC_CALL_CALL_H_
 #define WEBRTC_CALL_CALL_H_
 
+#include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "webrtc/api/rtcerror.h"
 #include "webrtc/base/networkroute.h"
 #include "webrtc/base/platform_file.h"
 #include "webrtc/base/socket.h"
 #include "webrtc/call/audio_receive_stream.h"
 #include "webrtc/call/audio_send_stream.h"
 #include "webrtc/call/audio_state.h"
 #include "webrtc/call/flexfec_receive_stream.h"
 #include "webrtc/call/rtp_transport_controller_send_interface.h"
 #include "webrtc/common_types.h"
 #include "webrtc/video_receive_stream.h"
 #include "webrtc/video_send_stream.h"
 
 namespace webrtc {
 
 class AudioProcessing;
 class RtcEventLog;
 
 enum class MediaType {
   ANY,
   AUDIO,
   VIDEO,
   DATA
 };
 
+template <typename T>
+static T MinPositive(T a, T b) {

[Taylor Brandstetter, 2017/06/09 17:43:58]

As long as we're moving this, can we add a comment explaining why it exists
(because we use "-1" to represent unset values, and sometimes need to take the
minimum of two maximums)? Just so it doesn't confuse people again in the future.
Could also add a TODO for removing or replacing it once we switch to
rtc::Optional

[holmer, 2017/06/12 11:46:56]

+1

+  if (a <= 0) {
+    return b;
+  }
+  if (b <= 0) {
+    return a;
+  }
+  return std::min(a, b);
+}
+
 class PacketReceiver {
  public:
   enum DeliveryStatus {
     DELIVERY_OK,
     DELIVERY_UNKNOWN_SSRC,
     DELIVERY_PACKET_ERROR,
   };
 
   virtual DeliveryStatus DeliverPacket(MediaType media_type,
                                        const uint8_t* packet,
@@ skipping 132 matching lines @@
       const rtc::NetworkRoute& network_route) = 0;
 
   virtual void OnSentPacket(const rtc::SentPacket& sent_packet) = 0;
 
   virtual ~Call() {}
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_CALL_CALL_H_