Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: webrtc/call/rtp_demuxer.h

Issue 2920993002: Add RSID-based demuxing to RtpDemuxer (Closed)
Patch Set: Missed one cast. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10
10 #ifndef WEBRTC_CALL_RTP_DEMUXER_H_ 11 #ifndef WEBRTC_CALL_RTP_DEMUXER_H_
11 #define WEBRTC_CALL_RTP_DEMUXER_H_ 12 #define WEBRTC_CALL_RTP_DEMUXER_H_
12 13
13 #include <map> 14 #include <map>
15 #include <set>
16 #include <string>
14 17
15 namespace webrtc { 18 namespace webrtc {
16 19
17 class RtpPacketReceived; 20 class RtpPacketReceived;
18 class RtpPacketSinkInterface; 21 class RtpPacketSinkInterface;
19 22
20 // This class represents the RTP demuxing, for a single RTP session (i.e., one 23 // This class represents the RTP demuxing, for a single RTP session (i.e., one
21 // ssrc space, see RFC 7656). It isn't thread aware, leaving responsibility of 24 // ssrc space, see RFC 7656). It isn't thread aware, leaving responsibility of
22 // multithreading issues to the user of this class. 25 // multithreading issues to the user of this class.
23 // TODO(nisse): Should be extended to also do MID-based demux and payload-type 26 // TODO(nisse): Should be extended to also do MID-based demux and payload-type
24 // demux. 27 // demux.
25 class RtpDemuxer { 28 class RtpDemuxer {
26 public: 29 public:
27 RtpDemuxer(); 30 RtpDemuxer();
28 ~RtpDemuxer(); 31 ~RtpDemuxer();
29 32
30 // Registers a sink. The same sink can be registered for multiple ssrcs, and 33 // Registers a sink. The same sink can be registered for multiple ssrcs, and
31 // the same ssrc can have multiple sinks. Null pointer is not allowed. 34 // the same ssrc can have multiple sinks. Null pointer is not allowed.
32 void AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink); 35 void AddSink(uint32_t ssrc, RtpPacketSinkInterface* sink);
33 // Removes a sink. Returns deletion count (a sink may be registered 36
34 // for multiple ssrcs). Null pointer is not allowed. 37 // Registers a sink's association to an RSID. Null pointer is not allowed.
35 size_t RemoveSink(const RtpPacketSinkInterface* sink); 38 void AddSink(const std::string& rsid, RtpPacketSinkInterface* sink);
39
40 // Removes a sink. Return value reports if anything was actually removed.
41 // Null pointer is not allowed.
42 bool RemoveSink(const RtpPacketSinkInterface* sink);
36 43
37 // Returns true if at least one matching sink was found, otherwise false. 44 // Returns true if at least one matching sink was found, otherwise false.
38 bool OnRtpPacket(const RtpPacketReceived& packet); 45 bool OnRtpPacket(const RtpPacketReceived& packet);
39 46
40 private: 47 private:
48 // Records a sink<->SSRC association. This can happen by explicit
49 // configuration by AddSink(ssrc...), or by inferred configuration from an
50 // RSID-based configuration which is resolved to an SSRC upon
51 // packet reception.
52 void RecordSsrcToSinkAssociation(uint32_t ssrc, RtpPacketSinkInterface* sink);
53
54 // When a new packet arrives, we attempt to resolve extra associations,
55 // such as which RSIDs are associated with which SSRCs.
56 void FindSsrcAssociations(const RtpPacketReceived& packet);
57
58 // This records the association SSRCs to sinks. Other associations, such
59 // as by RSID, also end up here once the RSID, etc., is resolved to an SSRC.
41 std::multimap<uint32_t, RtpPacketSinkInterface*> sinks_; 60 std::multimap<uint32_t, RtpPacketSinkInterface*> sinks_;
61
62 // A sink may be associated with an RSID - RTP Stream ID. This tag has a
63 // one-to-one association with an SSRC, but that SSRC is not yet known.
64 // When it becomes known, the association of the sink to the RSID is deleted
65 // from this container, and moved into |sinks_|.
66 std::multimap<std::string, RtpPacketSinkInterface*> rsid_sinks_;
67
68 // Iterating over |rsid_sinks_| for each incoming and performing multiple
69 // string comparisons is of non-trivial cost. To avoid this cost, we only
70 // check RSIDs for the first packet on each incoming SSRC stream.
71 // (If RSID associations are added later, we check again.)
72 std::set<uint32_t> processed_ssrcs_;
42 }; 73 };
43 74
44 } // namespace webrtc 75 } // namespace webrtc
45 76
46 #endif // WEBRTC_CALL_RTP_DEMUXER_H_ 77 #endif // WEBRTC_CALL_RTP_DEMUXER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/call/rtp_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698