Add RSID-based demuxing to RtpDemuxer

webrtc/common_types.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/common_types.h"
 
 #include <string.h>
+#include <algorithm>
 #include <limits>
 #include <type_traits>
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/stringutils.h"
 
 namespace webrtc {
 
 StreamDataCounters::StreamDataCounters() : first_packet_time_ms(-1) {}
 
 constexpr size_t StreamId::kMaxSize;
 
+bool StreamId::IsLegalName(const char* data, size_t size) {
+  return (size <= kMaxSize && size > 0 &&
+          std::all_of(data, data + size, isalnum));

[danilchap, 2017/06/02 17:42:20]

may be remove () around the expression.
https://google.github.io/styleguide/cppguide.html#Return_Values

[eladalon, 2017/06/02 19:44:05]

That link seems to suggest that the parenthesis are in fact okay in here.

[danilchap, 2017/06/07 13:45:41]

yep, in this case it is ok, thus 'may be'

+}
+
 void StreamId::Set(const char* data, size_t size) {
   // If |data| contains \0, the stream id size might become less than |size|.
-  RTC_DCHECK_LE(size, kMaxSize);
+  RTC_DCHECK_LE(size, kMaxSize);  // TODO(eladalon): IsLegalName?

[danilchap, 2017/06/02 17:42:20]

probably not:
Set is called by parser too. While parser should guarantee the size, it doesn't
check if name isalnum.
of-course it can't guarantee that other side put only allowed characters into
the buffer.

[eladalon, 2017/06/02 19:44:05]

My intention with this TODO is to come back to this at a later CL and change the
CHECK_LE into a CHECK(IsLegalName()), after the necessary extra work has been
done - making sure anyone who could call StreamId would fail gracefully instead
of calling StreamId() with a disallowed RSID. Wdyt?

[danilchap, 2017/06/07 13:45:41]

I prefer to think about StreamId as a special implementation of string (and
eventually plan to replace all uses of it by string) so prefer to put as little
as possible extra logic in it.

As for users of the StreamId - I do not think it would be benefitial to
check(IsLegalName()) when receiving a packet - illegal names will be discarded
automatically when compared to configured legal names.

   memcpy(value_, data, size);
   if (size < kMaxSize)
     value_[size] = 0;
 }
 
 // StreamId is used as member of RTPHeader that is sometimes copied with memcpy
 // and thus assume trivial destructibility.
 static_assert(std::is_trivially_destructible<StreamId>::value, "");
 
 RTPHeaderExtension::RTPHeaderExtension()
@@ skipping 156 matching lines @@
 // Get the sum of all the temporal layer for a specific spatial layer.
 uint32_t BitrateAllocation::GetSpatialLayerSum(size_t spatial_index) const {
   RTC_CHECK_LT(spatial_index, kMaxSpatialLayers);
   uint32_t sum = 0;
   for (int i = 0; i < kMaxTemporalStreams; ++i)
     sum += bitrates_[spatial_index][i];
   return sum;
 }
 
 }  // namespace webrtc