webrtc/modules/rtp_rtcp/source/flexfec_sender.cc - Issue 2918333002: Reland of Only compare sequence numbers from the same SSRC in ForwardErrorCorrection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/flexfec_sender.cc

Issue 2918333002: Reland of Only compare sequence numbers from the same SSRC in ForwardErrorCorrection. (Closed)

Patch Set: Let ForwardErrorCorrection be aware of its SSRCs. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/flexfec_sender.cc

diff --git a/webrtc/modules/rtp_rtcp/source/flexfec_sender.cc b/webrtc/modules/rtp_rtcp/source/flexfec_sender.cc

index feefe3d1ac302da62ff8bf3d0f8a5e89a3bf844e..7c69a99655183971397414f5753b04ba784cc586 100644

--- a/webrtc/modules/rtp_rtcp/source/flexfec_sender.cc

+++ b/webrtc/modules/rtp_rtcp/source/flexfec_sender.cc

@@ -80,7 +80,8 @@ FlexfecSender::FlexfecSender(

protected_media_ssrc_(protected_media_ssrc),

seq_num_(rtp_state ? rtp_state->sequence_number

: random_.Rand(1, kMaxInitRtpSeqNumber)),

- ulpfec_generator_(ForwardErrorCorrection::CreateFlexfec()),

+ ulpfec_generator_(

+ ForwardErrorCorrection::CreateFlexfec(ssrc, protected_media_ssrc)),

rtp_header_extension_map_(RegisterBweExtensions(rtp_header_extensions)),

header_extensions_size_(

rtp_header_extension_map_.GetTotalLengthInBytes(extension_sizes)) {