Replacing unnecessary conditional with DCHECK in OpenSSLAdapter

webrtc/base/openssladapter.cc

 /*
  *  Copyright 2008 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 547 matching lines @@
   // SSL_write uses the same arguments (though, with
   // SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER, the actual buffer pointer may be
   // different).
   //
   // However, after Send exits, we will have lost access to data the user of
   // this class is trying to send, and there's no guarantee that the user of
   // this class will call Send with the same arguements when it fails. So, we
   // buffer the data ourselves. When we know the underlying socket is writable
   // again from OnWriteEvent (or if Send is called again before that happens),
   // we'll retry sending this buffered data.
-  if ((error == SSL_ERROR_WANT_READ || error == SSL_ERROR_WANT_WRITE) &&
-      pending_data_.empty()) {
+  if (error == SSL_ERROR_WANT_READ || error == SSL_ERROR_WANT_WRITE) {
+    // Shouldn't be able to get to this point if we already have pending data.
+    RTC_DCHECK(pending_data_.empty());
     LOG(LS_WARNING)
         << "SSL_write couldn't write to the underlying socket; buffering data.";
     pending_data_.SetData(static_cast<const uint8_t*>(pv), cb);
     // Since we're taking responsibility for sending this data, return its full
     // size. The user of this class can consider it sent.
     return cb;
   }
 
   return ret;
 }
@@ skipping 419 matching lines @@
   SSL_CTX_set_cipher_list(ctx, "ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH");
 
   if (ssl_mode_ == SSL_MODE_DTLS) {
     SSL_CTX_set_read_ahead(ctx, 1);
   }
 
   return ctx;
 }
 
 } // namespace rtc