Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2917903002: Fix running unittests on iOS simulator (Closed)

Created:
3 years, 6 months ago by oprypin_webrtc
Modified:
3 years, 6 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix running unittests on iOS simulator WebRTC's unittest_main does not display anything on the screen of the device, so iOS would kill the application after 20 seconds because it's "frozen". So a different 'main' function is used here, one that references test_support_ios.mm which displays a dummy label while tests run. BUG=webrtc:7161

Patch Set 1 #

Patch Set 2 : Add dependencies #

Patch Set 3 : Rebase #

Patch Set 4 : Also fix test:test_main #

Patch Set 5 : Undo adding webrtc_nonparallel_tests. Flakes to be fixed separately #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M DEPS View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (21 generated)
oprypin_webrtc
Swapping out the main function obviously removes support for the command line flags that were ...
3 years, 6 months ago (2017-06-03 11:57:28 UTC) #22
kthelgason
3 years, 6 months ago (2017-06-07 08:24:01 UTC) #23
On 2017/06/03 11:57:28, oprypin_webrtc wrote:
> Swapping out the main function obviously removes support for the command line
> flags that were defined in WebRTC's code. I hoped that it would be OK, but
> apparently it isn't.
> This will need more work.

I'm very glad you're making progress here. Perhaps there is another way to pass
the command line args, like ENV vars? LMK if I can help in any way.

Powered by Google App Engine
This is Rietveld 408576698