Refactored incoming bitrate estimator.

webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
index dcec0f8000eca124b0acc066c40ac7278d30a0c1..a368658b7a10aa68bc642f511304503dc0cda343 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
@@ -27,7 +27,8 @@ const PacedPacketInfo kPacingInfo1(1, kNumProbesCluster1, 4000);
 
 TEST_F(DelayBasedBweTest, NoCrashEmptyFeedback) {
   std::vector<PacketFeedback> packet_feedback_vector;
-  bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector);
+  bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector,
+                                                   rtc::Optional<uint32_t>());

[terelius, 2017/06/02 12:14:05]

Do we have test coverage for the "typical" case where we actually do have an
acknowledged bitrate?

[tschumi, 2017/06/02 13:13:04]

Yes its done with the help of delay_based_bwe_unittest_helper

 }
 
 TEST_F(DelayBasedBweTest, NoCrashOnlyLostFeedback) {
@@ -36,7 +37,8 @@ TEST_F(DelayBasedBweTest, NoCrashOnlyLostFeedback) {
       PacketFeedback(-1, -1, 0, 1500, PacedPacketInfo()));
   packet_feedback_vector.push_back(
       PacketFeedback(-1, -1, 1, 1500, PacedPacketInfo()));
-  bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector);
+  bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector,
+                                                   rtc::Optional<uint32_t>());
 }
 
 TEST_F(DelayBasedBweTest, ProbeDetection) {