Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h

Issue 2917873002: Refactored incoming bitrate estimator. (Closed)
Patch Set: Responsed to comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h
diff --git a/webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h b/webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h
new file mode 100644
index 0000000000000000000000000000000000000000..f91a2808e98f1b8f51b303d842b3814bdfbfe939
--- /dev/null
+++ b/webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h
@@ -0,0 +1,46 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGE_BITRATE_ESTIMATOR_H_
+#define WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGE_BITRATE_ESTIMATOR_H_
+
+#include <vector>
+
+#include "webrtc/base/optional.h"
+#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
+
+namespace webrtc {
+
+// Computes a bayesian estimate of the throughput given acks containing
+// the arrival time and payload size. Samples which are far from the current
+// estimate or are based on few packets are given a smaller weight, as they
+// are considered to be more likely to have been caused by, e.g., delay spikes
+// unrelated to congestion.
+class AcknowledgedBitrateEstimator {
+ public:
+ AcknowledgedBitrateEstimator();
+ void IncomingPacketFeedbackVector(
+ const std::vector<PacketFeedback>& packet_feedback_vector);
philipel 2017/06/02 12:32:40 Isn't it possible to forward declare PacketFeedbac
tschumi 2017/06/02 13:13:04 Sure. Done
+
+ rtc::Optional<uint32_t> bitrate_bps() const;
+
+ private:
+ void Update(int64_t now_ms, int bytes);
+ float UpdateWindow(int64_t now_ms, int bytes, int rate_window_ms);
+ int sum_;
+ int64_t current_win_ms_;
+ int64_t prev_time_ms_;
+ float bitrate_estimate_;
+ float bitrate_estimate_var_;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_ACKNOWLEDGE_BITRATE_ESTIMATOR_H_

Powered by Google App Engine
This is Rietveld 408576698