webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 2917873002: Refactored incoming bitrate estimator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 2917873002: Refactored incoming bitrate estimator. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/send_side_congestion_controller.cc ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index 338c4d8e4d38f8d95da4fddf665247a70c301c02..df6228283633d1345efbc1b54fcdf3772f89b82f 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -13,6 +13,7 @@

#include <algorithm>

#include "webrtc/base/logging.h"

+#include "webrtc/base/ptr_util.h"

#include "webrtc/modules/congestion_controller/delay_based_bwe.h"

#include "webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"

@@ -29,7 +30,9 @@ SendSideBweSender::SendSideBweSender(int kbps,

BitrateController::CreateBitrateController(clock,

observer,

&event_log_)),

- bwe_(new DelayBasedBwe(nullptr, clock)),

+ incoming_bitrate_estimator_(rtc::MakeUnique<IncomingBitrateEstimator>()),

+ bwe_(

+ new DelayBasedBwe(nullptr, incoming_bitrate_estimator_.get(), clock)),

feedback_observer_(bitrate_controller_->CreateRtcpBandwidthObserver()),

clock_(clock),

send_time_history_(clock_, 10000),