Prevent memory corruption by StreamId::Set

webrtc/common_types.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/common_types.h"
 
 #include <string.h>
 #include <limits>
 #include <type_traits>
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/stringutils.h"
 
 namespace webrtc {
 
 StreamDataCounters::StreamDataCounters() : first_packet_time_ms(-1) {}
 
 constexpr size_t StreamId::kMaxSize;
 
 void StreamId::Set(const char* data, size_t size) {
   // If |data| contains \0, the stream id size might become less than |size|.
-  RTC_DCHECK_LE(size, kMaxSize);
+  RTC_CHECK_LE(size, kMaxSize);
   memcpy(value_, data, size);
   if (size < kMaxSize)
     value_[size] = 0;
 }
 
 // StreamId is used as member of RTPHeader that is sometimes copied with memcpy
 // and thus assume trivial destructibility.
 static_assert(std::is_trivially_destructible<StreamId>::value, "");
 
 RTPHeaderExtension::RTPHeaderExtension()
@@ skipping 156 matching lines @@
 // Get the sum of all the temporal layer for a specific spatial layer.
 uint32_t BitrateAllocation::GetSpatialLayerSum(size_t spatial_index) const {
   RTC_CHECK_LT(spatial_index, kMaxSpatialLayers);
   uint32_t sum = 0;
   for (int i = 0; i < kMaxTemporalStreams; ++i)
     sum += bitrates_[spatial_index][i];
   return sum;
 }
 
 }  // namespace webrtc