Delete SignalThread class.

webrtc/p2p/base/turnport.cc

 /*
  *  Copyright 2012 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 182 matching lines @@
     : Port(thread,
            RELAY_PORT_TYPE,
            factory,
            network,
            socket->GetLocalAddress().ipaddr(),
            username,
            password),
       server_address_(server_address),
       credentials_(credentials),
       socket_(socket),
-      resolver_(NULL),
+      resolver_(),

[tommi, 2017/06/19 13:01:47]

nit: remove from the initializer list since it'll be default constructed

[nisse-webrtc, 2017/06/19 14:07:20]

Done. Here and below.

       error_(0),
       request_manager_(thread),
       next_channel_number_(TURN_CHANNEL_NUMBER_START),
       state_(STATE_CONNECTING),
       server_priority_(server_priority),
       allocate_mismatch_retries_(0) {
   request_manager_.SignalSendPacket.connect(this, &TurnPort::OnSendStunPacket);
   request_manager_.set_origin(origin);
 }
 
@@ skipping 14 matching lines @@
            factory,
            network,
            ip,
            min_port,
            max_port,
            username,
            password),
       server_address_(server_address),
       credentials_(credentials),
       socket_(NULL),
-      resolver_(NULL),
+      resolver_(),

[tommi, 2017/06/19 13:01:47]

nit: remove (we don't include default constructed stl in initializer lists)

       error_(0),
       request_manager_(thread),
       next_channel_number_(TURN_CHANNEL_NUMBER_START),
       state_(STATE_CONNECTING),
       server_priority_(server_priority),
       allocate_mismatch_retries_(0) {
   request_manager_.SignalSendPacket.connect(this, &TurnPort::OnSendStunPacket);
   request_manager_.set_origin(origin);
 }
 
@@ skipping 423 matching lines @@
   attempted_server_addresses_.insert(server_address_.address);
   return true;
 }
 
 void TurnPort::ResolveTurnAddress(const rtc::SocketAddress& address) {
   if (resolver_)
     return;
 
   LOG_J(LS_INFO, this) << "Starting TURN host lookup for "
                        << address.ToSensitiveString();
-  resolver_ = socket_factory()->CreateAsyncResolver();
+  resolver_ = rtc::WrapUnique(socket_factory()->CreateAsyncResolver());
   resolver_->SignalDone.connect(this, &TurnPort::OnResolveResult);
   resolver_->Start(address);
 }
 
 void TurnPort::OnResolveResult(rtc::AsyncResolverInterface* resolver) {
-  RTC_DCHECK(resolver == resolver_);
+  RTC_DCHECK(resolver == resolver_.get());
   // If DNS resolve is failed when trying to connect to the server using TCP,
   // one of the reason could be due to DNS queries blocked by firewall.
   // In such cases we will try to connect to the server with hostname, assuming
   // socket layer will resolve the hostname through a HTTP proxy (if any).
   if (resolver_->GetError() != 0 && server_address_.proto == PROTO_TCP) {
     if (!CreateTurnClientSocket()) {
       OnAllocateError();
     }
     return;
   }
@@ skipping 883 matching lines @@
   } else {
     state_ = STATE_UNBOUND;
     port_->FailAndPruneConnection(ext_addr_);
   }
 }
 void TurnEntry::OnChannelBindTimeout() {
   state_ = STATE_UNBOUND;
   port_->FailAndPruneConnection(ext_addr_);
 }
 }  // namespace cricket