Delete SignalThread class.

webrtc/base/nethelpers.h

 /*
  *  Copyright 2008 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_NETHELPERS_H_
 #define WEBRTC_BASE_NETHELPERS_H_
 
 #if defined(WEBRTC_POSIX)
 #include <netdb.h>
 #include <stddef.h>
 #elif WEBRTC_WIN
 #include <winsock2.h>  // NOLINT
 #endif
 
 #include <list>
 
 #include "webrtc/base/asyncresolverinterface.h"
-#include "webrtc/base/signalthread.h"
+#include "webrtc/base/platform_thread.h"
 #include "webrtc/base/sigslot.h"
 #include "webrtc/base/socketaddress.h"
 
 namespace rtc {
 
-class AsyncResolverTest;
+class Thread;
 
-// AsyncResolver will perform async DNS resolution, signaling the result on
-// the SignalDone from AsyncResolverInterface when the operation completes.
-class AsyncResolver : public SignalThread, public AsyncResolverInterface {
+// AsyncResolver will perform async DNS resolution, signaling the result on the
+// SignalDone from AsyncResolverInterface when the operation completes.
+// SignalDone is fired on the same thread on which the AsyncResolver was
+// constructed.
+class AsyncResolver : public AsyncResolverInterface {
  public:
   AsyncResolver();
   ~AsyncResolver() override;
 
   void Start(const SocketAddress& addr) override;
   bool GetResolvedAddress(int family, SocketAddress* addr) const override;
   int GetError() const override;
   void Destroy(bool wait) override;
 
   const std::vector<IPAddress>& addresses() const { return addresses_; }
   void set_error(int error) { error_ = error; }
 
- protected:
-  void DoWork() override;
-  void OnWorkDone() override;
+ private:
+  // Worker thread main function.
+  static void ThreadEntry_w(void* p);
+  void ResolveAddress_w();
 
- private:
+  void ResolveDone(int error, std::vector<IPAddress> addresses);

[tommi, 2017/06/15 10:20:32]

passing by value intentionally? If so, a comment about ownership passing would
be nice

[nisse-webrtc, 2017/06/15 11:33:47]

I was aiming to keep this as simple as possible, and I don't think performance
matters much here. Do you think pass-by-value + std::move is good enough? I you
prefer, I could change it to std::unique_ptr<std::vector>.

+
+  rtc::Thread* construction_thread_;

[tommi, 2017/06/15 10:20:32]

rtc::Thread* const construction_thread_;

[nisse-webrtc, 2017/06/15 11:33:47]

Done.

+  PlatformThread worker_;

[tommi, 2017/06/15 10:20:32]

nit: resolve_thread_

[nisse-webrtc, 2017/06/15 11:33:47]

Not doing this now, since I'll attempt to replace it with a TaskQueue.

   SocketAddress addr_;
   std::vector<IPAddress> addresses_;
-  int error_;
+  int error_ = -1;
 };
 
 // rtc namespaced wrappers for inet_ntop and inet_pton so we can avoid
 // the windows-native versions of these.
 const char* inet_ntop(int af, const void *src, char* dst, socklen_t size);
 int inet_pton(int af, const char* src, void *dst);
 
 bool HasIPv4Enabled();
 bool HasIPv6Enabled();
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_NETHELPERS_H_