Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h

Issue 2913793002: Address some violations of chromium-style. (Closed)
Patch Set: Add empty line. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
diff --git a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
index aab953c319e9a99e8555ef2ca26bc44019719676..0177b8180fc738002ec5d7b716a97638260882b2 100644
--- a/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
+++ b/webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h
@@ -43,7 +43,7 @@ struct ReceiveBandwidthEstimatorStats {};
class RemoteBitrateEstimator : public CallStatsObserver, public Module {
public:
- virtual ~RemoteBitrateEstimator() {}
+ ~RemoteBitrateEstimator() override {}
// Called for each incoming packet. Updates the incoming payload bitrate
// estimate and the over-use detector. If an over-use is detected the
@@ -64,9 +64,7 @@ class RemoteBitrateEstimator : public CallStatsObserver, public Module {
uint32_t* bitrate_bps) const = 0;
// TODO(holmer): Remove when all implementations have been updated.
- virtual bool GetStats(ReceiveBandwidthEstimatorStats* output) const {
- return false;
- }
+ virtual bool GetStats(ReceiveBandwidthEstimatorStats* output) const;
virtual void SetMinBitrate(int min_bitrate_bps) = 0;
@@ -75,6 +73,11 @@ class RemoteBitrateEstimator : public CallStatsObserver, public Module {
static const int64_t kStreamTimeOutMs = 2000;
};
+inline bool RemoteBitrateEstimator::GetStats(
+ ReceiveBandwidthEstimatorStats* output) const {
+ return false;
+}
+
} // namespace webrtc
#endif // WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_INCLUDE_REMOTE_BITRATE_ESTIMATOR_H_
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h ('k') | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698