Re-enable EndToEndTest.PictureIdStateRetainedAfterReinitingVp8 on tsan.

webrtc/video/end_to_end_tests.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include <algorithm>
@@ skipping 4108 matching lines @@
   reinit_encoder_and_test(1);
   reinit_encoder_and_test(1);
 
   send_transport.StopSending();
   receive_transport.StopSending();
 
   Stop();
   DestroyStreams();
 }
 
-// These tests exposed a race in libvpx, see
-// https://bugs.chromium.org/p/webrtc/issues/detail?id=7663. Disabling the tests
-// on tsan until the race has been fixed.
-#if defined(THREAD_SANITIZER)
-#define MAYBE_PictureIdStateRetainedAfterReinitingVp8 \
-  DISABLED_PictureIdStateRetainedAfterReinitingVp8
-#define MAYBE_PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter \
-  DISABLED_PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter
-#else
-#define MAYBE_PictureIdStateRetainedAfterReinitingVp8 \
-  PictureIdStateRetainedAfterReinitingVp8
-#define MAYBE_PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter \
-  PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter
-#endif
-TEST_F(EndToEndTest, MAYBE_PictureIdStateRetainedAfterReinitingVp8) {
+TEST_F(EndToEndTest, PictureIdStateRetainedAfterReinitingVp8) {
   std::unique_ptr<VideoEncoder> encoder(VP8Encoder::Create());
   TestPictureIdStatePreservation(encoder.get());
 }
 
+TEST_F(EndToEndTest,

[brandtr, 2017/06/01 09:36:25]

Moved this test for better ordering in the file.

+       PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter) {
+  class VideoEncoderFactoryAdapter : public webrtc::VideoEncoderFactory {
+   public:
+    explicit VideoEncoderFactoryAdapter(
+        cricket::WebRtcVideoEncoderFactory* factory)
+        : factory_(factory) {}
+    virtual ~VideoEncoderFactoryAdapter() {}
+
+    // Implements webrtc::VideoEncoderFactory.
+    webrtc::VideoEncoder* Create() override {
+      return factory_->CreateVideoEncoder(
+          cricket::VideoCodec(cricket::kVp8CodecName));
+    }
+
+    void Destroy(webrtc::VideoEncoder* encoder) override {
+      return factory_->DestroyVideoEncoder(encoder);
+    }
+
+   private:
+    cricket::WebRtcVideoEncoderFactory* const factory_;
+  };
+
+  cricket::InternalEncoderFactory internal_encoder_factory;
+  SimulcastEncoderAdapter simulcast_encoder_adapter(
+      new VideoEncoderFactoryAdapter(&internal_encoder_factory));
+
+  TestPictureIdStatePreservation(&simulcast_encoder_adapter);
+}
+
 // This test is flaky on linux_memcheck. Disable on all linux bots until
 // flakyness has been fixed.
 // https://bugs.chromium.org/p/webrtc/issues/detail?id=7737
 #if defined(WEBRTC_LINUX)
 #define MAYBE_TestFlexfecRtpStatePreservation \
   DISABLED_TestFlexfecRtpStatePreservation
 #else
 #define MAYBE_TestFlexfecRtpStatePreservation TestFlexfecRtpStatePreservation
 #endif
 TEST_F(EndToEndTest, MAYBE_TestFlexfecRtpStatePreservation) {
@@ skipping 148 matching lines @@
   frame_generator_capturer_->Start();
   EXPECT_TRUE(observer.Wait()) << "Timed out waiting for packets.";
 
   // Cleanup.
   send_transport.StopSending();
   receive_transport.StopSending();
   Stop();
   DestroyStreams();
 }
 
-TEST_F(EndToEndTest,
-       MAYBE_PictureIdStateRetainedAfterReinitingSimulcastEncoderAdapter) {
-  class VideoEncoderFactoryAdapter : public webrtc::VideoEncoderFactory {
-   public:
-    explicit VideoEncoderFactoryAdapter(
-        cricket::WebRtcVideoEncoderFactory* factory)
-        : factory_(factory) {}
-    virtual ~VideoEncoderFactoryAdapter() {}
-
-    // Implements webrtc::VideoEncoderFactory.
-    webrtc::VideoEncoder* Create() override {
-      return factory_->CreateVideoEncoder(
-          cricket::VideoCodec(cricket::kVp8CodecName));
-    }
-
-    void Destroy(webrtc::VideoEncoder* encoder) override {
-      return factory_->DestroyVideoEncoder(encoder);
-    }
-
-   private:
-    cricket::WebRtcVideoEncoderFactory* const factory_;
-  };
-
-  cricket::InternalEncoderFactory internal_encoder_factory;
-  SimulcastEncoderAdapter simulcast_encoder_adapter(
-      new VideoEncoderFactoryAdapter(&internal_encoder_factory));
-
-  TestPictureIdStatePreservation(&simulcast_encoder_adapter);
-}
-
 TEST_F(EndToEndTest, RespectsNetworkState) {
   // TODO(pbos): Remove accepted downtime packets etc. when signaling network
   // down blocks until no more packets will be sent.
 
   // Pacer will send from its packet list and then send required padding before
   // checking paused_ again. This should be enough for one round of pacing,
   // otherwise increase.
   static const int kNumAcceptedDowntimeRtp = 5;
   // A single RTCP may be in the pipeline.
   static const int kNumAcceptedDowntimeRtcp = 1;
@@ skipping 571 matching lines @@
     std::unique_ptr<VideoEncoder> encoder_;
     std::unique_ptr<VideoDecoder> decoder_;
     rtc::CriticalSection crit_;
     int recorded_frames_ GUARDED_BY(crit_);
   } test(this);
 
   RunBaseTest(&test);
 }
 
 }  // namespace webrtc