Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2912113002: Ensure the RtcEventLog parser is backwards compatible (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/event_log_visualizer/analyzer.cc
diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc
index f42855fa92c1a40bf62a021ebae7bc7e28cd1344..ee41ecc527179fcc2c9ac2385f19ffe55ed2bd5e 100644
--- a/webrtc/tools/event_log_visualizer/analyzer.cc
+++ b/webrtc/tools/event_log_visualizer/analyzer.cc
@@ -331,8 +331,7 @@ EventLogAnalyzer::EventLogAnalyzer(const ParsedRtcEventLog& log)
switch (parsed_log_.GetEventType(i)) {
case ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT: {
- rtclog::StreamConfig config;
- parsed_log_.GetVideoReceiveConfig(i, &config);
+ rtclog::StreamConfig config = parsed_log_.GetVideoReceiveConfig(i);
StreamId stream(config.remote_ssrc, kIncomingPacket);
extension_maps[stream] = RtpHeaderExtensionMap(config.rtp_extensions);
video_ssrcs_.insert(stream);
@@ -344,29 +343,30 @@ EventLogAnalyzer::EventLogAnalyzer(const ParsedRtcEventLog& log)
break;
}
case ParsedRtcEventLog::VIDEO_SENDER_CONFIG_EVENT: {
- rtclog::StreamConfig config;
- parsed_log_.GetVideoSendConfig(i, &config);
- StreamId stream(config.local_ssrc, kOutgoingPacket);
- extension_maps[stream] = RtpHeaderExtensionMap(config.rtp_extensions);
- video_ssrcs_.insert(stream);
- StreamId rtx_stream(config.rtx_ssrc, kOutgoingPacket);
- extension_maps[rtx_stream] =
- RtpHeaderExtensionMap(config.rtp_extensions);
- video_ssrcs_.insert(rtx_stream);
- rtx_ssrcs_.insert(rtx_stream);
+ std::vector<rtclog::StreamConfig> configs =
+ parsed_log_.GetVideoSendConfig(i);
+ for (size_t j = 0; j < configs.size(); j++) {
+ StreamId stream(configs[i].local_ssrc, kOutgoingPacket);
+ extension_maps[stream] =
+ RtpHeaderExtensionMap(configs[i].rtp_extensions);
+ video_ssrcs_.insert(stream);
+ StreamId rtx_stream(configs[i].rtx_ssrc, kOutgoingPacket);
+ extension_maps[rtx_stream] =
+ RtpHeaderExtensionMap(configs[i].rtp_extensions);
+ video_ssrcs_.insert(rtx_stream);
+ rtx_ssrcs_.insert(rtx_stream);
+ }
break;
}
case ParsedRtcEventLog::AUDIO_RECEIVER_CONFIG_EVENT: {
- rtclog::StreamConfig config;
- parsed_log_.GetAudioReceiveConfig(i, &config);
+ rtclog::StreamConfig config = parsed_log_.GetAudioReceiveConfig(i);
StreamId stream(config.remote_ssrc, kIncomingPacket);
extension_maps[stream] = RtpHeaderExtensionMap(config.rtp_extensions);
audio_ssrcs_.insert(stream);
break;
}
case ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT: {
- rtclog::StreamConfig config;
- parsed_log_.GetAudioSendConfig(i, &config);
+ rtclog::StreamConfig config = parsed_log_.GetAudioSendConfig(i);
StreamId stream(config.local_ssrc, kOutgoingPacket);
extension_maps[stream] = RtpHeaderExtensionMap(config.rtp_extensions);
audio_ssrcs_.insert(stream);
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698