Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Fix CE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h b/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
index a1f69dd0f962cdc875d2e8b14704ec3eee8dad35..944c58132221ff7ac8b85b1e9fc573df19eb535f 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h
@@ -15,6 +15,7 @@
#include "webrtc/api/video/video_content_type.h"
#include "webrtc/api/video/video_rotation.h"
+#include "webrtc/api/video/video_timing.h"
#include "webrtc/base/array_view.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@@ -126,6 +127,23 @@ class VideoContentTypeExtension {
static bool Write(uint8_t* data, VideoContentType content_type);
};
+class VideoTimingExtension {
+ public:
+ static constexpr RTPExtensionType kId = kRtpExtensionVideoTiming;
+ static constexpr uint8_t kValueSizeBytes = 12;
+ static constexpr const char* kUri =
+ "http://www.webrtc.org/experiments/rtp-hdrext/video-timing";
+
+ static bool Parse(rtc::ArrayView<const uint8_t> data, VideoTiming* timing);
+ static size_t ValueSize(VideoTiming) { return kValueSizeBytes; }
åsapersson 2017/06/12 14:33:41 const VideoTiming&
ilnik 2017/06/13 08:43:13 Done.
+ static size_t ValueSize(uint16_t delta_ms, uint8_t idx) {
åsapersson 2017/06/12 14:33:41 maybe move to line 143 above Write
åsapersson 2017/06/12 14:33:41 time_delta_ms
ilnik 2017/06/13 08:43:13 Done.
+ return kValueSizeBytes;
+ }
+ static bool Write(uint8_t* data, const VideoTiming& timing);
+ // Writes only single time delta to position idx.
+ static bool Write(uint8_t* data, uint16_t time_delta_ms, uint8_t idx);
+};
+
class RtpStreamId {
public:
static constexpr RTPExtensionType kId = kRtpExtensionRtpStreamId;

Powered by Google App Engine
This is Rietveld 408576698