Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: webrtc/test/frame_generator_capturer.cc

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Fix capture timestamp issues which cause capture time from the future Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/test/frame_generator_capturer.cc
diff --git a/webrtc/test/frame_generator_capturer.cc b/webrtc/test/frame_generator_capturer.cc
index bd3f8ca2a0839371df981313b854df182cfc9e8e..c114e0e098a591216e6d44741f6a165180317c1c 100644
--- a/webrtc/test/frame_generator_capturer.cc
+++ b/webrtc/test/frame_generator_capturer.cc
@@ -160,7 +160,7 @@ void FrameGeneratorCapturer::InsertFrame() {
rtc::CritScope cs(&lock_);
if (sending_) {
VideoFrame* frame = frame_generator_->NextFrame();
- frame->set_timestamp_us(rtc::TimeMicros());
+ frame->set_timestamp_us(clock_->TimeInMicroseconds());
ilnik 2017/06/01 12:33:37 For consistency.
nisse-webrtc 2017/06/02 12:04:55 I'd rather move in the opposite direction. The fra
ilnik 2017/06/02 13:02:21 I believe we should use clock_ instead of wallcloc
sprang_webrtc 2017/06/09 11:02:01 Agree that we should move towards rtc::TimeMicros
frame->set_ntp_time_ms(clock_->CurrentNtpInMilliseconds());
frame->set_rotation(fake_rotation_);
if (first_frame_capture_time_ == -1) {

Powered by Google App Engine
This is Rietveld 408576698