Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: webrtc/api/video/video_timing.h

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Fix capture timestamp issues which cause capture time from the future Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/video/video_timing.h
diff --git a/webrtc/api/video/video_timing.h b/webrtc/api/video/video_timing.h
new file mode 100644
index 0000000000000000000000000000000000000000..256ae3e6a9846493ef03b4355cc52236cadd1032
--- /dev/null
+++ b/webrtc/api/video/video_timing.h
@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_API_VIDEO_VIDEO_TIMING_H_
+#define WEBRTC_API_VIDEO_VIDEO_TIMING_H_
+
+#include <stdint.h>
+#include <limits>
+#include "webrtc/base/checks.h"
+
+namespace webrtc {
+
+// Video timing timstamps in ms counted from capture_time_ms of a frame.
+struct VideoTiming {
+ static const uint8_t kEncodeStartDeltaIdx = 0;
+ static const uint8_t kEncodeFinishIdx = 1;
+ static const uint8_t kPacketizationFinishDeltaIdx = 2;
+ static const uint8_t kPacerExitDeltaIdx = 3;
+ static const uint8_t kNetworkTimestampDeltaIdx = 4;
+
+ // Returns |time_ms - base_ms| capped at max 16-bit value.
+ // Used to fill this data structure as per
+ // https://webrtc.org/experiments/rtp-hdrext/video-timing/ extension stores
+ // 16-bit deltas of timestamps from packet capture time.
+ static uint16_t GetDeltaCappedMs(int64_t base_ms, int64_t time_ms) {
+ RTC_DCHECK_GE(time_ms, base_ms);
ilnik 2017/06/01 12:33:37 Is this a good idea to crash here in debug? Should
+ int64_t delta = time_ms - base_ms;
+ if (delta > std::numeric_limits<uint16_t>::max())
+ delta = std::numeric_limits<uint16_t>::max();
+ return static_cast<uint16_t>(delta);
+ }
+
+ uint16_t encode_start_ms_delta;
+ uint16_t encode_finish_ms_delta;
+ uint16_t packetization_finish_ms_delta;
+ uint16_t pacer_exit_ms_delta;
+ uint16_t network_timstamp_ms_delta;
+ bool is_timing_frame;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_API_VIDEO_VIDEO_TIMING_H_

Powered by Google App Engine
This is Rietveld 408576698