Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webrtc/common_types.h

Issue 2911193002: Implement timing frames. (Closed)
Patch Set: Fix uninitialized variables memcheck errors Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index 424afd91397414a18c6f8d96e45da4d4a73f36db..f52cab7c3f1325a826a9460e80bd094bd2f10af4 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -20,6 +20,7 @@
#include "webrtc/api/video/video_content_type.h"
#include "webrtc/api/video/video_rotation.h"
+#include "webrtc/api/video/video_timing.h"
#include "webrtc/base/array_view.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/optional.h"
@@ -588,6 +589,10 @@ class VideoCodec {
VideoCodecMode mode;
bool expect_encode_from_texture;
+ // Timing frames configuration.
sprang_webrtc 2017/05/31 11:12:54 I think you can expand this comment; it's not obvi
ilnik 2017/05/31 15:17:45 Done.
+ int64_t timingFramesDelayMs;
+ size_t minFrameSizeToForceTimingFrameBytes;
sprang_webrtc 2017/05/31 11:12:54 Thinking some more on this, not sure bytes is the
sprang_webrtc 2017/05/31 11:12:55 Maybe we can make these a named struct, since they
ilnik 2017/05/31 15:17:45 Nice idea. Done.
ilnik 2017/05/31 15:17:45 Done.
+
bool operator==(const VideoCodec& other) const = delete;
bool operator!=(const VideoCodec& other) const = delete;
@@ -761,6 +766,9 @@ struct RTPHeaderExtension {
bool hasVideoContentType;
VideoContentType videoContentType;
+ bool hasVideoTiming;
+ VideoTiming videoTiming;
+
PlayoutDelay playout_delay = {-1, -1};
// For identification of a stream when ssrc is not signaled. See

Powered by Google App Engine
This is Rietveld 408576698