webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h - Issue 2911193002: Implement timing frames.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

Issue 2911193002: Implement timing frames. (Closed)

Patch Set: Fix uninitialized variables memcheck errors Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/rtp_rtcp/source/rtp_utility.cc ('K') | « webrtc/modules/video_coding/codec_database.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc » ('j') | webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 *	9 *

10 */	10 */

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90	90

91 size_t max_payload_size_;	91 size_t max_payload_size_;

92 int32_t number_of_cores_;	92 int32_t number_of_cores_;

93	93

94 EncodedImage encoded_image_;	94 EncodedImage encoded_image_;

95 std::unique_ptr<uint8_t[]> encoded_image_buffer_;	95 std::unique_ptr<uint8_t[]> encoded_image_buffer_;

96 EncodedImageCallback* encoded_image_callback_;	96 EncodedImageCallback* encoded_image_callback_;

97	97

98 bool has_reported_init_;	98 bool has_reported_init_;

99 bool has_reported_error_;	99 bool has_reported_error_;

	100

	101 int64_t last_timing_frame_time_ms_;

	102 // Timing frames config.

	103 int64_t timing_frames_delay_ms_;

	104 size_t min_frame_size_to_force_timing_frame_bytes_;
	sprang_webrtc 2017/05/31 11:12:55 These two can be const? These two can be const? ilnik 2017/05/31 15:17:45 Unfortunately, no. They are initialized in runtime Show quoted text On 2017/05/31 11:12:55, sprang_webrtc wrote: > These two can be const? Unfortunately, no. They are initialized in runtime by InitEncode. Passing initialization values to constructor will complicate code a lot.
100 };	105 };

101	106

102 } // namespace webrtc	107 } // namespace webrtc

103	108

104 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_	109 #endif // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_

OLD	NEW