Implement timing frames.

webrtc/common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_COMMON_TYPES_H_
 #define WEBRTC_COMMON_TYPES_H_
 
 #include <stddef.h>
 #include <string.h>
 
 #include <ostream>
 #include <string>
 #include <vector>
 
 #include "webrtc/api/video/video_content_type.h"
 #include "webrtc/api/video/video_rotation.h"
+#include "webrtc/api/video/video_timing.h"
 #include "webrtc/base/array_view.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/optional.h"
 #include "webrtc/typedefs.h"
 
 #if defined(_MSC_VER)
 // Disable "new behavior: elements of array will be default initialized"
 // warning. Affects OverUseDetectorOptions.
 #pragma warning(disable : 4351)
 #endif
@@ skipping 548 matching lines @@
   uint32_t maxFramerate;
 
   unsigned int qpMax;
   unsigned char numberOfSimulcastStreams;
   SimulcastStream simulcastStream[kMaxSimulcastStreams];
   SpatialLayer spatialLayers[kMaxSpatialLayers];
 
   VideoCodecMode mode;
   bool expect_encode_from_texture;
 
+  // Timing frames configuration.

[sprang_webrtc, 2017/05/31 11:12:54]

I think you can expand this comment; it's not obvious to me what these values
will do.

[ilnik, 2017/05/31 15:17:45]

Done.

+  int64_t timingFramesDelayMs;
+  size_t minFrameSizeToForceTimingFrameBytes;

[sprang_webrtc, 2017/05/31 11:12:54]

Thinking some more on this, not sure bytes is the right type, as a frame being
"large" is a function of the current bitrate and framerate.
Maybe it can be a factor of the ideal frame size instead?

[sprang_webrtc, 2017/05/31 11:12:55]

Maybe we can make these a named struct, since they seem to be passed around as a
pair. Something like TimingFrameTriggerThresholds or so, then you could simple
name the members delay_ms and min_frame_size_bytes?
Up to you. 

[ilnik, 2017/05/31 15:17:45]

Nice idea. Done.

[ilnik, 2017/05/31 15:17:45]

Done.

+
   bool operator==(const VideoCodec& other) const = delete;
   bool operator!=(const VideoCodec& other) const = delete;
 
   // Accessors for codec specific information.
   // There is a const version of each that returns a reference,
   // and a non-const version that returns a pointer, in order
   // to allow modification of the parameters.
   VideoCodecVP8* VP8();
   const VideoCodecVP8& VP8() const;
   VideoCodecVP9* VP9();
@@ skipping 149 matching lines @@
   bool voiceActivity;
   uint8_t audioLevel;
 
   // For Coordination of Video Orientation. See
   // http://www.etsi.org/deliver/etsi_ts/126100_126199/126114/12.07.00_60/
   // ts_126114v120700p.pdf
   bool hasVideoRotation;
   VideoRotation videoRotation;
 
   // TODO(ilnik): Refactor this and one above to be rtc::Optional() and remove
   // a corresponding bool flag.

[sprang_webrtc, 2017/05/31 11:12:54]

So we now have three of these bool + value. Time to do that refactoring? :)

[ilnik, 2017/05/31 15:17:45]

Maybe, there are some complications about that. Will it be safe to memset()
rtc::optional (RTP header is memset all other the place)/ Either way, it's a job
for a separate CL.

   bool hasVideoContentType;
   VideoContentType videoContentType;
 
+  bool hasVideoTiming;
+  VideoTiming videoTiming;
+
   PlayoutDelay playout_delay = {-1, -1};
 
   // For identification of a stream when ssrc is not signaled. See
   // https://tools.ietf.org/html/draft-ietf-avtext-rid-09
   // TODO(danilchap): Update url from draft to release version.
   StreamId stream_id;
   StreamId repaired_stream_id;
 };
 
 struct RTPHeader {
@@ skipping 112 matching lines @@
 enum class RtcpMode { kOff, kCompound, kReducedSize };
 
 enum NetworkState {
   kNetworkUp,
   kNetworkDown,
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_