Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2909543003: Use unnamed namespaces instead of static functions in CSSAnimations.cpp (Closed)

Created:
3 years, 7 months ago by alancutter (OOO until 2018)
Modified:
3 years, 6 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unnamed namespaces instead of static functions in CSSAnimations.cpp https: //chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Unnamed-namespaces Review-Url: https://codereview.chromium.org/2909543003 Cr-Commit-Position: refs/heads/master@{#476188} Committed: https://chromium.googlesource.com/chromium/src/+/c898ba0ca498623ec89becbe014fd70d176981c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 8 chunks +18 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
alancutter (OOO until 2018)
3 years, 7 months ago (2017-05-26 05:06:24 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-26 05:08:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909543003/1
3 years, 6 months ago (2017-06-01 04:17:03 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 04:21:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c898ba0ca498623ec89becbe014f...

Powered by Google App Engine
This is Rietveld 408576698