Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: components/exo/keyboard.cc

Issue 2906803002: Rename MaximizeMode to TabletMode (Closed)
Patch Set: updated filter Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/keyboard.cc
diff --git a/components/exo/keyboard.cc b/components/exo/keyboard.cc
index fd261e1ec9dc0aee123cddf5def1db6844d62f5f..5359c84d5f334659315edeb93e6b9ed5ce668315 100644
--- a/components/exo/keyboard.cc
+++ b/components/exo/keyboard.cc
@@ -75,8 +75,8 @@ bool ConsumedByIme(Surface* focus, const ui::KeyEvent* event) {
}
bool IsPhysicalKeyboardEnabled() {
- // The internal keyboard is enabled if maximize mode is not enabled.
- if (!WMHelper::GetInstance()->IsMaximizeModeWindowManagerEnabled())
+ // The internal keyboard is enabled if tablet mode is not enabled.
+ if (!WMHelper::GetInstance()->IsTabletModeWindowManagerEnabled())
return true;
for (auto& keyboard :
@@ -96,7 +96,7 @@ Keyboard::Keyboard(KeyboardDelegate* delegate) : delegate_(delegate) {
auto* helper = WMHelper::GetInstance();
helper->AddPostTargetHandler(this);
helper->AddFocusObserver(this);
- helper->AddMaximizeModeObserver(this);
+ helper->AddTabletModeObserver(this);
helper->AddInputDeviceEventObserver(this);
OnWindowFocused(helper->GetFocusedWindow(), nullptr);
}
@@ -110,7 +110,7 @@ Keyboard::~Keyboard() {
auto* helper = WMHelper::GetInstance();
helper->RemoveFocusObserver(this);
helper->RemovePostTargetHandler(this);
- helper->RemoveMaximizeModeObserver(this);
+ helper->RemoveTabletModeObserver(this);
helper->RemoveInputDeviceEventObserver(this);
}
@@ -215,15 +215,15 @@ void Keyboard::OnKeyboardDeviceConfigurationChanged() {
}
////////////////////////////////////////////////////////////////////////////////
-// WMHelper::MaximizeModeObserver overrides:
+// WMHelper::TabletModeObserver overrides:
-void Keyboard::OnMaximizeModeStarted() {
+void Keyboard::OnTabletModeStarted() {
OnKeyboardDeviceConfigurationChanged();
}
-void Keyboard::OnMaximizeModeEnding() {}
+void Keyboard::OnTabletModeEnding() {}
-void Keyboard::OnMaximizeModeEnded() {
+void Keyboard::OnTabletModeEnded() {
OnKeyboardDeviceConfigurationChanged();
}

Powered by Google App Engine
This is Rietveld 408576698